third_party/WebKit/LayoutTests/html/menu_menuitem/menuitem-label.html - Issue 2841473002: Implement HTMLMenuItemElement.label

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/html/menu_menuitem/menuitem-label.html

Issue 2841473002: Implement HTMLMenuItemElement.label (Closed)

Patch Set: Fix syntax error Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	tkent 2017/04/25 23:24:59 This is a conformance test without any Blink-speci This is a conformance test without any Blink-specific part. We should put this into LayoutTests/external/wpt/html/semantics/interactive-elements/the-menuitem-element/. yuzuchan 2017/04/26 08:54:56 Done. Show quoted text On 2017/04/25 at 23:24:59, tkent wrote: > This is a conformance test without any Blink-specific part. We should put this into LayoutTests/external/wpt/html/semantics/interactive-elements/the-menuitem-element/. Done.
	2 <script src='../../resources/testharness.js'></script>

	3 <script src='../../resources/testharnessreport.js'></script>

	4 <menuitem id='item1' label='item1'></menuitem>

	5 <menuitem id='item2'>item2</menuitem>

	6 <menuitem id='item3'>item 3</menuitem>

	7 <menuitem id='item4' label=''>item4</menuitem>

	8
	tkent 2017/04/25 23:24:59 We need test cases with - leading/trailing whitesp We need test cases with - leading/trailing whitespaces in textContent - leading/trailing/sequence-of whitespaces in label attribute yuzuchan 2017/04/26 08:54:56 Done. Show quoted text On 2017/04/25 at 23:24:59, tkent wrote: > We need test cases with > - leading/trailing whitespaces in textContent > - leading/trailing/sequence-of whitespaces in label attribute Done.
	9 <script>

	10 test(() => {

	11 var item1 = document.getElementById('item1');
	tkent 2017/04/25 23:24:59 Variable \|item1\| isn't so helpful. We can write si Variable \|item1\| isn't so helpful. We can write simply: assert_equals(document.querySelector('#item1').label, 'item1'); yuzuchan 2017/04/26 08:54:56 Done. Show quoted text On 2017/04/25 at 23:24:59, tkent wrote: > Variable \|item1\| isn't so helpful. We can write simply: > assert_equals(document.querySelector('#item1').label, 'item1'); Done.
	12 var item2 = document.getElementById('item2');

	13 assert_equals(item1.label, 'item1');

	14 assert_equals(item2.label, 'item2');

	15 assert_equals(item3.label, 'item 3');

	16 assert_equals(item4.label, 'item4');

	17 }, 'Menuitem.label should be the label attribute content or the result of '

	18 + 'stripping and collapsing ASCII whitespace from the child text content.');

	19 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLMenuItemElement.h » ('j') | third_party/WebKit/Source/core/html/HTMLMenuItemElement.h » ('J')