third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc - Issue 2841463003: scheduler: Make virtual time expiration deterministic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc

Issue 2841463003: scheduler: Make virtual time expiration deterministic (Closed)

Patch Set: Review comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc ('K') | « third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc ('k') | third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc

diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc

index 022f2cd8f4f22f2a2df17d90e3ef0e502b1e87e2..c6d6e700a7dcc38dc34ed5b1c95e7c44b48de678 100644

--- a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc

+++ b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc

@@ -3666,6 +3666,8 @@ TEST_F(RendererSchedulerImplTest, EnableVirtualTime) {

scheduler_->GetVirtualTimeDomain());

EXPECT_EQ(scheduler_->TimerTaskQueue()->GetTimeDomain(),

scheduler_->GetVirtualTimeDomain());

+ EXPECT_EQ(scheduler_->ControlTaskQueue()->GetTimeDomain(),

+ scheduler_->GetVirtualTimeDomain());

EXPECT_EQ(loading_tq->GetTimeDomain(), scheduler_->GetVirtualTimeDomain());

EXPECT_EQ(timer_tq->GetTimeDomain(), scheduler_->GetVirtualTimeDomain());

@@ -3700,6 +3702,8 @@ TEST_F(RendererSchedulerImplTest, DisableVirtualTimeForTesting) {

scheduler_->real_time_domain());

EXPECT_EQ(scheduler_->TimerTaskQueue()->GetTimeDomain(),

scheduler_->real_time_domain());

+ EXPECT_EQ(scheduler_->ControlTaskQueue()->GetTimeDomain(),

+ scheduler_->real_time_domain());

}

TEST_F(RendererSchedulerImplTest, Tracing) {