Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

Issue 2841463003: scheduler: Make virtual time expiration deterministic (Closed)
Patch Set: Rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
index d7db5c181d72fc60ada9f14321dada6b1694cf49..f3369ecb1d37ebb10a89938fb290bf28bd1e0067 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
@@ -309,6 +309,11 @@ scoped_refptr<TaskQueue> RendererSchedulerImpl::ControlTaskQueue() {
return helper_.ControlTaskQueue();
}
+scoped_refptr<TaskQueue> RendererSchedulerImpl::VirtualTimeControlTaskQueue() {
+ helper_.CheckOnValidThread();
+ return virtual_time_control_task_queue_;
+}
+
scoped_refptr<TaskQueue> RendererSchedulerImpl::NewLoadingTaskQueue(
TaskQueue::QueueType queue_type) {
helper_.CheckOnValidThread();
@@ -1851,6 +1856,13 @@ void RendererSchedulerImpl::EnableVirtualTime() {
for (const scoped_refptr<TaskQueue>& task_queue : unthrottled_task_runners_)
task_queue->SetTimeDomain(time_domain);
+ DCHECK(!virtual_time_control_task_queue_);
+ virtual_time_control_task_queue_ =
+ helper_.NewTaskQueue(TaskQueue::Spec(TaskQueue::QueueType::CONTROL));
+ virtual_time_control_task_queue_->SetQueuePriority(
+ TaskQueue::CONTROL_PRIORITY);
+ virtual_time_control_task_queue_->SetTimeDomain(time_domain);
+
ForceUpdatePolicy();
}
@@ -1861,6 +1873,8 @@ void RendererSchedulerImpl::DisableVirtualTimeForTesting() {
// The |unthrottled_task_runners_| are not actively managed by UpdatePolicy().
for (const scoped_refptr<TaskQueue>& task_queue : unthrottled_task_runners_)
task_queue->SetTimeDomain(time_domain);
+ virtual_time_control_task_queue_->UnregisterTaskQueue();
+ virtual_time_control_task_queue_ = nullptr;
ForceUpdatePolicy();
}

Powered by Google App Engine
This is Rietveld 408576698