Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: content/browser/devtools/protocol/devtools_protocol_browsertest.cc

Issue 2841463003: scheduler: Make virtual time expiration deterministic (Closed)
Patch Set: Rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/protocol/devtools_protocol_browsertest.cc
diff --git a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
index 286e78b33bdc14790491072c454d117704a4bb45..fcf8b12a5fb95f573a9cab2f213ecd74b47533c9 100644
--- a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
+++ b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
@@ -1379,18 +1379,17 @@ IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, VirtualTimeTest) {
params->SetString("policy", "pause");
SendCommand("Emulation.setVirtualTimePolicy", std::move(params), true);
- // TODO(scheduler-dev): Revisit timing when we have strict ordering
- // guarantees.
params.reset(new base::DictionaryValue());
params->SetString("expression",
- "setTimeout(function(){console.log('before')}, 1000);"
- "setTimeout(function(){console.log('after')}, 1002);");
+ "setTimeout(function(){console.log('before')}, 999);"
+ "setTimeout(function(){console.log('at')}, 1000);"
+ "setTimeout(function(){console.log('after')}, 1001);");
SendCommand("Runtime.evaluate", std::move(params), true);
// Let virtual time advance for one second.
params.reset(new base::DictionaryValue());
params->SetString("policy", "advance");
- params->SetInteger("budget", 1001);
+ params->SetInteger("budget", 1000);
SendCommand("Emulation.setVirtualTimePolicy", std::move(params), true);
WaitForNotification("Emulation.virtualTimeBudgetExpired");
@@ -1411,7 +1410,7 @@ IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, VirtualTimeTest) {
WaitForNotification("Emulation.virtualTimeBudgetExpired");
- EXPECT_THAT(console_messages_, ElementsAre("before", "done", "after"));
+ EXPECT_THAT(console_messages_, ElementsAre("before", "done", "at", "after"));
}
// Tests that the Security.showCertificateViewer command shows the
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698