scheduler: Make virtual time expiration deterministic

third_party/WebKit/Source/web/InspectorEmulationAgent.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "web/InspectorEmulationAgent.h"
 
 #include "core/frame/FrameView.h"
 #include "core/frame/Settings.h"
 #include "core/inspector/protocol/DOM.h"
 #include "core/page/Page.h"
@@ skipping 153 matching lines @@
   } else if (protocol::Emulation::VirtualTimePolicyEnum::
                  PauseIfNetworkFetchesPending == policy) {
     web_local_frame_impl_->View()->Scheduler()->SetVirtualTimePolicy(
         WebViewScheduler::VirtualTimePolicy::DETERMINISTIC_LOADING);
   }
   web_local_frame_impl_->View()->Scheduler()->EnableVirtualTime();
 
   if (budget.isJust()) {
     RefPtr<WebTaskRunner> task_runner =
         Platform::Current()->CurrentThread()->GetWebTaskRunner();
-    long long delay_millis = static_cast<long long>(budget.fromJust());
-    virtual_time_budget_expired_task_handle_ =

[dgozman, 2017/04/24 17:10:30]

nit: remove the field.

[Sami, 2017/04/24 17:33:47]

Done!

-        task_runner->PostDelayedCancellableTask(
-            BLINK_FROM_HERE,
-            WTF::Bind(&InspectorEmulationAgent::VirtualTimeBudgetExpired,
-                      WrapWeakPersistent(this)),
-            delay_millis);
+    base::TimeDelta budget_amount = base::TimeDelta::FromMilliseconds(
+        budget.fromJust());
+    web_local_frame_impl_->View()->Scheduler()->GrantVirtualTimeBudget(
+        budget_amount,
+        WTF::Bind(&InspectorEmulationAgent::VirtualTimeBudgetExpired,
+                  WrapWeakPersistent(this)));
   }
   return Response::OK();
 }
 
 void InspectorEmulationAgent::VirtualTimeBudgetExpired() {
   web_local_frame_impl_->View()->Scheduler()->SetVirtualTimePolicy(
       WebViewScheduler::VirtualTimePolicy::PAUSE);
   GetFrontend()->virtualTimeBudgetExpired();
 }
 
@@ skipping 15 matching lines @@
       Color(rgba->getR(), rgba->getG(), rgba->getB(), alpha).Rgb());
   return Response::OK();
 }
 
 DEFINE_TRACE(InspectorEmulationAgent) {
   visitor->Trace(web_local_frame_impl_);
   InspectorBaseAgent::Trace(visitor);
 }
 
 }  // namespace blink