pdf/pdfium/pdfium_engine.cc - Issue 2841443005: [Bindings] Create and use V8 context snapshots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pdf/pdfium/pdfium_engine.cc

Issue 2841443005: [Bindings] Create and use V8 context snapshots (Closed)

Patch Set: Fix tests and introduce RuntimeEnabled flag Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pdf/pdfium/pdfium_engine.cc

diff --git a/pdf/pdfium/pdfium_engine.cc b/pdf/pdfium/pdfium_engine.cc

index 5bd7fed6e85d7b4df98c989425b57f25564d5d53..9a8365914547520455d0b1c506204e558c853d3b 100644

--- a/pdf/pdfium/pdfium_engine.cc

+++ b/pdf/pdfium/pdfium_engine.cc

@@ -594,8 +594,8 @@ void SetUpV8() {

gin::IsolateHolder::Initialize(gin::IsolateHolder::kNonStrictMode,

gin::IsolateHolder::kStableV8Extras,

gin::ArrayBufferAllocator::SharedInstance());

- g_isolate_holder = new gin::IsolateHolder(base::ThreadTaskRunnerHandle::Get(),

- gin::IsolateHolder::kSingleThread);

+ g_isolate_holder =

+ new gin::IsolateHolder(base::ThreadTaskRunnerHandle::Get());

g_isolate_holder->isolate()->Enter();

}