Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3219)

Unified Diff: content/test/test_blink_web_unit_test_support.cc

Issue 2841443005: [Bindings] Create and use V8 context snapshots (Closed)
Patch Set: Fix tests and introduce RuntimeEnabled flag Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/test_blink_web_unit_test_support.cc
diff --git a/content/test/test_blink_web_unit_test_support.cc b/content/test/test_blink_web_unit_test_support.cc
index 50349664235ffdc85142758a54fe5e39cf43dedc..590d7c2f81384600453c97e9453dff31075d1e31 100644
--- a/content/test/test_blink_web_unit_test_support.cc
+++ b/content/test/test_blink_web_unit_test_support.cc
@@ -24,6 +24,7 @@
#include "content/child/web_url_loader_impl.h"
#include "content/test/mock_webclipboard_impl.h"
#include "content/test/web_gesture_curve_mock.h"
+#include "gin/v8_initializer.h" // nogncheck
#include "media/base/media.h"
#include "media/media_features.h"
#include "net/cookies/cookie_monster.h"
@@ -45,9 +46,6 @@
#include "base/mac/scoped_nsautorelease_pool.h"
#endif
-#ifdef V8_USE_EXTERNAL_STARTUP_DATA
-#include "gin/v8_initializer.h" // nogncheck
-#endif
#if BUILDFLAG(ENABLE_WEBRTC)
#include "content/renderer/media/rtc_certificate.h"
@@ -105,6 +103,7 @@ TestBlinkWebUnitTestSupport::TestBlinkWebUnitTestSupport() {
gin::V8Initializer::LoadV8Snapshot();
gin::V8Initializer::LoadV8Natives();
#endif
+ gin::V8Initializer::LoadV8Context();
scoped_refptr<base::SingleThreadTaskRunner> dummy_task_runner;
std::unique_ptr<base::ThreadTaskRunnerHandle> dummy_task_runner_handle;

Powered by Google App Engine
This is Rietveld 408576698