Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: third_party/WebKit/Source/controller/BlinkInitializer.cpp

Issue 2841443005: [Bindings] Create and use V8 context snapshots (Closed)
Patch Set: Work for comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/controller/BlinkInitializer.cpp
diff --git a/third_party/WebKit/Source/controller/BlinkInitializer.cpp b/third_party/WebKit/Source/controller/BlinkInitializer.cpp
index 8add6961771033aaec8662195b2bc2ac3ee6bb32..df89ba451de540cabe8ff092657b325ccd0426bf 100644
--- a/third_party/WebKit/Source/controller/BlinkInitializer.cpp
+++ b/third_party/WebKit/Source/controller/BlinkInitializer.cpp
@@ -31,6 +31,7 @@
#include "controller/BlinkInitializer.h"
#include "bindings/core/v8/V8Initializer.h"
+#include "bindings/modules/v8/V8ContextSnapshotExternalReferences.h"
#include "core/animation/AnimationClock.h"
#include "modules/ModulesInitializer.h"
#include "platform/bindings/Microtask.h"
@@ -69,8 +70,9 @@ static ModulesInitializer& GetModulesInitializer() {
void InitializeBlink(Platform* platform) {
Platform::Initialize(platform);
- V8Initializer::InitializeMainThread();
-
+ // Refernce table must be updated before creating an isolate.
haraken 2017/07/10 06:52:09 reference We could drop this comment because now
peria 2017/07/10 10:18:43 Done.
+ V8Initializer::InitializeMainThread(
+ V8ContextSnapshotExternalReferences::GetTable());
GetModulesInitializer().Initialize();
// currentThread is null if we are running on a thread without a message loop.

Powered by Google App Engine
This is Rietveld 408576698