third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp - Issue 2841443005: [Bindings] Create and use V8 context snapshots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp

Issue 2841443005: [Bindings] Create and use V8 context snapshots (Closed)

Patch Set: Work for yuki's comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8SnapshotUtil.cpp ('K') | « third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventTarget.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp » ('j') | third_party/WebKit/Source/platform/bindings/ScriptWrappableVisitor.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp

index 5fe2ce02de5d4d86fc6fc1794fd41cac4ad2cd3a..570e57e2759a7cc3d7f5f1b56a37460dd368b07e 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp

@@ -384,7 +384,10 @@ void V8TestInterfaceGarbageCollected::constructorCallback(const v8::FunctionCall

TestInterfaceGarbageCollectedV8Internal::constructor(info);

}

-static void installV8TestInterfaceGarbageCollectedTemplate(v8::Isolate* isolate, const DOMWrapperWorld& world, v8::Local<v8::FunctionTemplate> interfaceTemplate) {

+static void installV8TestInterfaceGarbageCollectedTemplate(

+ v8::Isolate* isolate,

+ const DOMWrapperWorld& world,

+ v8::Local<v8::FunctionTemplate> interfaceTemplate) {

// Initialize the interface object's template.

V8DOMConfiguration::InitializeDOMInterfaceTemplate(isolate, interfaceTemplate, V8TestInterfaceGarbageCollected::wrapperTypeInfo.interface_name, V8EventTarget::domTemplate(isolate, world), V8TestInterfaceGarbageCollected::internalFieldCount);

interfaceTemplate->SetCallHandler(V8TestInterfaceGarbageCollected::constructorCallback);

@@ -397,7 +400,7 @@ static void installV8TestInterfaceGarbageCollectedTemplate(v8::Isolate* isolate,

v8::Local<v8::ObjectTemplate> prototypeTemplate = interfaceTemplate->PrototypeTemplate();

ALLOW_UNUSED_LOCAL(prototypeTemplate);

- // Register DOM constants, attributes and operations.

+ // Register IDL constants, attributes and operations.

V8DOMConfiguration::InstallAccessors(isolate, world, instanceTemplate, prototypeTemplate, interfaceTemplate, signature, V8TestInterfaceGarbageCollectedAccessors, WTF_ARRAY_LENGTH(V8TestInterfaceGarbageCollectedAccessors));

V8DOMConfiguration::InstallMethods(isolate, world, instanceTemplate, prototypeTemplate, interfaceTemplate, signature, V8TestInterfaceGarbageCollectedMethods, WTF_ARRAY_LENGTH(V8TestInterfaceGarbageCollectedMethods));