third_party/WebKit/Source/bindings/tests/results/modules/V8TestSubObject.cpp - Issue 2841443005: [Bindings] Create and use V8 context snapshots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/modules/V8TestSubObject.cpp

Issue 2841443005: [Bindings] Create and use V8 context snapshots (Closed)

Patch Set: Support runtime feature on templates Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl ('K') | « third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp ('k') | third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/modules/V8TestSubObject.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/modules/V8TestSubObject.cpp b/third_party/WebKit/Source/bindings/tests/results/modules/V8TestSubObject.cpp

index 55df9f49632c3171ed3680562c84f7932662eb21..a2bbf52ac7716f3fa980dcc6813787442a402826 100644

--- a/third_party/WebKit/Source/bindings/tests/results/modules/V8TestSubObject.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/modules/V8TestSubObject.cpp

@@ -145,7 +145,10 @@ static const V8DOMConfiguration::AccessorConfiguration V8TestSubObjectAccessors[

{ "unforgeableLongAttribute", V8TestSubObject::unforgeableLongAttributeAttributeGetterCallback, V8TestSubObject::unforgeableLongAttributeAttributeSetterCallback, nullptr, nullptr, static_cast<v8::PropertyAttribute>(v8::DontDelete), V8DOMConfiguration::kOnInstance, V8DOMConfiguration::kCheckHolder, V8DOMConfiguration::kAllWorlds },

};

-static void installV8TestSubObjectTemplate(v8::Isolate* isolate, const DOMWrapperWorld& world, v8::Local<v8::FunctionTemplate> interfaceTemplate) {

+static void installV8TestSubObjectTemplate(

+ v8::Isolate* isolate,

+ const DOMWrapperWorld& world,

+ v8::Local<v8::FunctionTemplate> interfaceTemplate) {

// Initialize the interface object's template.

V8DOMConfiguration::InitializeDOMInterfaceTemplate(isolate, interfaceTemplate, V8TestSubObject::wrapperTypeInfo.interface_name, V8TestObject::domTemplate(isolate, world), V8TestSubObject::internalFieldCount);