third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceDocument.cpp - Issue 2841443005: [Bindings] Create and use V8 context snapshots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceDocument.cpp

Issue 2841443005: [Bindings] Create and use V8 context snapshots (Closed)

Patch Set: Support runtime feature on templates Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl ('K') | « third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCustomConstructor.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEmpty.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceDocument.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceDocument.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceDocument.cpp

index 66142c2a085af716de378ca4ddda44e44ddecf12..73c134becdd7e240f0a004e6feae14715921226f 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceDocument.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceDocument.cpp

@@ -115,7 +115,10 @@ static const V8DOMConfiguration::AccessorConfiguration V8TestInterfaceDocumentAc

{ "location", V8TestInterfaceDocument::locationAttributeGetterCallback, V8TestInterfaceDocument::locationAttributeSetterCallback, nullptr, nullptr, static_cast<v8::PropertyAttribute>(v8::DontDelete), V8DOMConfiguration::kOnInstance, V8DOMConfiguration::kCheckHolder, V8DOMConfiguration::kAllWorlds },

};

-static void installV8TestInterfaceDocumentTemplate(v8::Isolate* isolate, const DOMWrapperWorld& world, v8::Local<v8::FunctionTemplate> interfaceTemplate) {

+static void installV8TestInterfaceDocumentTemplate(

+ v8::Isolate* isolate,

+ const DOMWrapperWorld& world,

+ v8::Local<v8::FunctionTemplate> interfaceTemplate) {

// Initialize the interface object's template.

V8DOMConfiguration::InitializeDOMInterfaceTemplate(isolate, interfaceTemplate, V8TestInterfaceDocument::wrapperTypeInfo.interface_name, V8Document::domTemplate(isolate, world), V8TestInterfaceDocument::internalFieldCount);