third_party/WebKit/Source/bindings/templates/partial_interface.h.tmpl - Issue 2841443005: [Bindings] Create and use V8 context snapshots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/partial_interface.h.tmpl

Issue 2841443005: [Bindings] Create and use V8 context snapshots (Closed)

Patch Set: Work for all comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8SnapshotUtil.cpp ('K') | « third_party/WebKit/Source/bindings/templates/partial_interface.cpp.tmpl ('k') | third_party/WebKit/Source/bindings/templates/templates.gni » ('j') | third_party/WebKit/Source/platform/bindings/ScriptWrappable.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/partial_interface.h.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/partial_interface.h.tmpl b/third_party/WebKit/Source/bindings/templates/partial_interface.h.tmpl

index d2b9a5706920a3dfdcb60e0a4668d913b2738c5a..80a1c6ad554d163f2060f0a08a621cbb38742905 100644

--- a/third_party/WebKit/Source/bindings/templates/partial_interface.h.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/partial_interface.h.tmpl

@@ -42,9 +42,9 @@ class {{v8_class_or_partial}} {

{% endfor %}

{% if needs_runtime_enabled_installer %}

- static void installRuntimeEnabledFeatures(

- v8::Isolate* isolate,

- const DOMWrapperWorld& world,

+ static void InstallRuntimeEnabledFeatures(

+ v8::Isolate*,

+ const DOMWrapperWorld&,

v8::Local<v8::Object> instance,

v8::Local<v8::Object> prototype,

v8::Local<v8::Function> interface);