Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/BUILD.gn

Issue 2841443005: [Bindings] Create and use V8 context snapshots (Closed)
Patch Set: Work for most comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« gin/v8_initializer.cc ('K') | « gin/v8_initializer.cc ('k') | pdf/pdfium/pdfium_engine.cc » ('j') | third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/BUILD.gn
diff --git a/net/BUILD.gn b/net/BUILD.gn
index 6b6dbf8297db54f0a4a407a0e15078921cfc818e..0c9a6b4c8559d1fb718b216452d08358d0262e33 100644
--- a/net/BUILD.gn
+++ b/net/BUILD.gn
@@ -2079,7 +2079,8 @@ component("net") {
}
# ICU support.
- if (use_platform_icu_alternatives) {
+ if (use_platform_icu_alternatives &&
+ current_toolchain == default_toolchain) {
if (is_android) {
# Use ICU alternative on Android.
sources += [ "base/net_string_util_icu_alternatives_android.cc" ]
« gin/v8_initializer.cc ('K') | « gin/v8_initializer.cc ('k') | pdf/pdfium/pdfium_engine.cc » ('j') | third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698