Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

Issue 2841443005: [Bindings] Create and use V8 context snapshots (Closed)
Patch Set: Work for some comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
index 3f96785ec0575cca1228567a66c748abcf30d2a7..ff4d08fb824e367ca0d4ee838525e175168f9b8d 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
@@ -40,6 +40,7 @@
#include "bindings/core/v8/V8ErrorHandler.h"
#include "bindings/core/v8/V8GCController.h"
#include "bindings/core/v8/V8IdleTaskRunner.h"
+#include "bindings/core/v8/V8SnapshotCreator.h"
#include "bindings/core/v8/WorkerOrWorkletScriptController.h"
#include "core/dom/Document.h"
#include "core/dom/ExecutionContext.h"
@@ -434,14 +435,19 @@ void V8Initializer::InitializeMainThread() {
v8_extras_mode, &array_buffer_allocator);
// NOTE: Some threads (namely utility threads) don't have a scheduler.
- WebScheduler* scheduler = Platform::Current()->CurrentThread()->Scheduler();
+ WebThread* thread = Platform::Current()->CurrentThread();
+ WebScheduler* scheduler = thread ? thread->Scheduler() : nullptr;
+
// When timer task runner is used for PerIsolateData, GC tasks are getting
// throttled and memory usage goes up. For now we're using loading task queue
// to prevent this.
// TODO(altimin): Consider switching to timerTaskRunner here.
v8::Isolate* isolate = V8PerIsolateData::Initialize(
scheduler ? scheduler->LoadingTaskRunner()
- : Platform::Current()->CurrentThread()->GetWebTaskRunner());
+ : thread ? thread->GetWebTaskRunner() : nullptr,
+ V8SnapshotCreator::GetReferenceTable(),
+ V8SnapshotCreator::TakingSnapshot() ? gin::IsolateHolder::kTakeSnapshot
+ : gin::IsolateHolder::kUseSnapshot);
InitializeV8Common(isolate);

Powered by Google App Engine
This is Rietveld 408576698