third_party/WebKit/public/web/SnapshotCreator.h - Issue 2841443005: [Bindings] Create and use V8 context snapshots

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/public/web/SnapshotCreator.h

Issue 2841443005: [Bindings] Create and use V8 context snapshots (Closed)

Patch Set: Fix some behaviors Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef SnapshotCreator_h

	6 #define SnapshotCreator_h

	7

	8 #include <cstdint>
	Yuki 2017/05/12 15:20:11 I'm curious about why we need <cstdint>. I'm curious about why we need <cstdint>. peria 2017/05/30 08:25:43 Acknowledged. Show quoted text On 2017/05/12 15:20:11, Yuki wrote: > I'm curious about why we need <cstdint>. Acknowledged.
	9 #include "public/platform/WebCommon.h"

	10 #include "v8/include/v8.h"

	11

	12 namespace blink {

	13

	14 class BLINK_EXPORT SnapshotCreator {

	15 public:

	16 // static intptr_t* getExternalReferences();
	Yuki 2017/05/12 15:20:11 Remove this line. Remove this line. peria 2017/05/30 08:25:43 Done. Show quoted text On 2017/05/12 15:20:11, Yuki wrote: > Remove this line. Done.
	17 static void TakeSnapshot(v8::SnapshotCreator*, int worldId);

	18 static v8::StartupData SetUpSnapshotCreator(v8::SnapshotCreator*);

	19 static v8::SnapshotCreator* GetSnapshotCreator();

	20 static v8::StartupData Serialize(v8::Local<v8::Object>, int index, void*);

	21 static void SetTakingSnapshot(bool);

	22 };

	23

	24 } // namespace blink

	25

	26 #endif // SnapshotCreator_h

OLD	NEW