third_party/WebKit/Source/bindings/templates/templates.gni - Issue 2841443005: [Bindings] Create and use V8 context snapshots

Side by Side Diff: third_party/WebKit/Source/bindings/templates/templates.gni

Issue 2841443005: [Bindings] Create and use V8 context snapshots (Closed)

Patch Set: Fix some behaviors Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« third_party/WebKit/Source/bindings/scripts/scripts.gni ('K') | « third_party/WebKit/Source/bindings/templates/snapshot.cpp.tmpl ('k') | third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp » ('j') | third_party/WebKit/Source/platform/bindings/V8DOMWrapper.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 # Paths should be absolute so this file can be imported from anywhere.	5 # Paths should be absolute so this file can be imported from anywhere.

6 code_generator_template_files =	6 code_generator_template_files =

7 get_path_info([	7 get_path_info([

8 "attributes.cpp.tmpl",	8 "attributes.cpp.tmpl",

9 "callback_function.cpp.tmpl",	9 "callback_function.cpp.tmpl",

10 "callback_function.h.tmpl",	10 "callback_function.h.tmpl",

11 "callback_interface.cpp.tmpl",	11 "callback_interface.cpp.tmpl",

12 "callback_interface.h.tmpl",	12 "callback_interface.h.tmpl",

13 "constants.cpp.tmpl",	13 "constants.cpp.tmpl",

14 "utilities.cpp.tmpl",	14 "utilities.cpp.tmpl",

15 "copyright_block.txt",	15 "copyright_block.txt",

16 "dictionary_impl.cpp.tmpl",	16 "dictionary_impl.cpp.tmpl",

17 "dictionary_impl.h.tmpl",	17 "dictionary_impl.h.tmpl",

18 "dictionary_v8.cpp.tmpl",	18 "dictionary_v8.cpp.tmpl",

19 "dictionary_v8.h.tmpl",	19 "dictionary_v8.h.tmpl",

20 "interface_base.cpp.tmpl",	20 "interface_base.cpp.tmpl",

21 "interface.cpp.tmpl",	21 "interface.cpp.tmpl",

22 "interface.h.tmpl",	22 "interface.h.tmpl",

23 "legacy_callback_interface.cpp.tmpl",	23 "legacy_callback_interface.cpp.tmpl",

24 "legacy_callback_interface.h.tmpl",	24 "legacy_callback_interface.h.tmpl",

25 "methods.cpp.tmpl",	25 "methods.cpp.tmpl",

26 "partial_interface.cpp.tmpl",	26 "partial_interface.cpp.tmpl",

27 "partial_interface.h.tmpl",	27 "partial_interface.h.tmpl",

	28 "snapshot.cpp.tmpl",
	Yuki 2017/05/12 15:20:10 s/snapshot/snapshot_reference/ following the class s/snapshot/snapshot_reference/ following the class name? I think that "snapshot_external_reference" is a better name, though. My understanding is that: - snapshot = a serialized blob - snapshot reference = a reference to a snapshot? or external references? better than "snapshot", but still a bit unclear. - snapshot external references = a list of external references for a snapshot. peria 2017/06/01 08:33:31 Done. Show quoted text On 2017/05/12 15:20:10, Yuki wrote: > s/snapshot/snapshot_reference/ > following the class name? > > I think that "snapshot_external_reference" is a better name, though. My > understanding is that: > - snapshot = a serialized blob > - snapshot reference = a reference to a snapshot? or external references? > better than "snapshot", but still a bit unclear. > - snapshot external references = a list of external references for a snapshot. Done.
28 "union_container.cpp.tmpl",	29 "union_container.cpp.tmpl",

29 "union_container.h.tmpl",	30 "union_container.h.tmpl",

30 "web_agent_api_interface.cc.tmpl",	31 "web_agent_api_interface.cc.tmpl",

31 "web_agent_api_interface.h.tmpl",	32 "web_agent_api_interface.h.tmpl",

32 ],	33 ],

33 "abspath")	34 "abspath")

OLD	NEW