Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

Issue 2841443005: [Bindings] Create and use V8 context snapshots (Closed)
Patch Set: Fix some behaviors Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009, 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2008, 2009, 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 19 matching lines...) Expand all
30 30
31 #include "bindings/core/v8/WindowProxy.h" 31 #include "bindings/core/v8/WindowProxy.h"
32 32
33 #include <utility> 33 #include <utility>
34 34
35 #include "bindings/core/v8/V8BindingForCore.h" 35 #include "bindings/core/v8/V8BindingForCore.h"
36 #include "bindings/core/v8/V8GCForContextDispose.h" 36 #include "bindings/core/v8/V8GCForContextDispose.h"
37 #include "core/frame/DOMWindow.h" 37 #include "core/frame/DOMWindow.h"
38 #include "core/frame/Frame.h" 38 #include "core/frame/Frame.h"
39 #include "platform/bindings/V8DOMWrapper.h" 39 #include "platform/bindings/V8DOMWrapper.h"
40 #include "platform/instrumentation/tracing/TraceEvent.h"
Yuki 2017/05/12 15:20:10 Why do we need this here?
peria 2017/05/30 08:25:42 Done.
40 #include "platform/wtf/Assertions.h" 41 #include "platform/wtf/Assertions.h"
41 #include "v8/include/v8.h" 42 #include "v8/include/v8.h"
42 43
43 namespace blink { 44 namespace blink {
44 45
45 WindowProxy::~WindowProxy() { 46 WindowProxy::~WindowProxy() {
46 // clearForClose() or clearForNavigation() must be invoked before destruction 47 // clearForClose() or clearForNavigation() must be invoked before destruction
47 // starts. 48 // starts.
48 DCHECK(lifecycle_ != Lifecycle::kContextIsInitialized); 49 DCHECK(lifecycle_ != Lifecycle::kContextIsInitialized);
49 } 50 }
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 wrapper)) { 158 wrapper)) {
158 WrapperTypeInfo::WrapperCreated(); 159 WrapperTypeInfo::WrapperCreated();
159 V8DOMWrapper::SetNativeInfo(isolate_, wrapper, wrapper_type_info, window); 160 V8DOMWrapper::SetNativeInfo(isolate_, wrapper, wrapper_type_info, window);
160 DCHECK(V8DOMWrapper::HasInternalFieldsSet(wrapper)); 161 DCHECK(V8DOMWrapper::HasInternalFieldsSet(wrapper));
161 } 162 }
162 SECURITY_CHECK(ToScriptWrappable(wrapper) == window); 163 SECURITY_CHECK(ToScriptWrappable(wrapper) == window);
163 return wrapper; 164 return wrapper;
164 } 165 }
165 166
166 } // namespace blink 167 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698