build/config/features.gni - Issue 2841443005: [Bindings] Create and use V8 context snapshots

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/config/features.gni

Issue 2841443005: [Bindings] Create and use V8 context snapshots (Closed)

Patch Set: Work for nits and libc fix? Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/BUILD.gn » ('j') | tools/v8_context_snapshot/BUILD.gn » ('J')

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 # =============================================	5 # =============================================

6 # PLEASE DO NOT ADD MORE FLAGS TO THIS FILE	6 # PLEASE DO NOT ADD MORE FLAGS TO THIS FILE

7 # =============================================	7 # =============================================

8 #	8 #

9 # These flags are effectively global. Your feature flag should go near the	9 # These flags are effectively global. Your feature flag should go near the

10 # code it controls. Most of these items are here now because they control	10 # code it controls. Most of these items are here now because they control

(...skipping 43 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
54 # Note: this setting is ignored if is_chrome_branded.	54 # Note: this setting is ignored if is_chrome_branded.

55 fieldtrial_testing_like_official_build = is_chrome_branded	55 fieldtrial_testing_like_official_build = is_chrome_branded

56	56

57 # libudev usage. This currently only affects the content layer.	57 # libudev usage. This currently only affects the content layer.

58 use_udev = is_linux && !is_chromecast	58 use_udev = is_linux && !is_chromecast

59	59

60 use_dbus = is_linux && !is_chromecast	60 use_dbus = is_linux && !is_chromecast

61	61

62 # Option controlling the use of GConf (the classic GNOME configuration	62 # Option controlling the use of GConf (the classic GNOME configuration

63 # system).	63 # system).

64 use_gconf = is_linux && !is_chromeos && !is_chromecast	64 use_gconf = is_linux && !is_chromeos && !is_chromecast &&

	65 current_toolchain == default_toolchain
	Nico 2017/07/11 18:59:39 Why do you need this? Why do you need this? peria 2017/07/12 02:38:37 gconf has an assert to check it. And if current_TC Show quoted text On 2017/07/11 18:59:39, Nico (vacation Jun 30-Jul 11) wrote: > Why do you need this? gconf has an assert to check it. And if current_TC != default_TC, target_os is not Linux, and I believe GNOME is not necessary for server side programs on Linux.
65	66

66 use_gio = is_linux && !is_chromeos && !is_chromecast	67 use_gio = is_linux && !is_chromeos && !is_chromecast

67 }	68 }

68 #	69 #

69 # =============================================	70 # =============================================

70 # PLEASE DO NOT ADD MORE FLAGS TO THIS FILE	71 # PLEASE DO NOT ADD MORE FLAGS TO THIS FILE

71 # =============================================	72 # =============================================

72 #	73 #

73 # See comment at the top.	74 # See comment at the top.

OLD	NEW