On 2017/07/04 15:04:20, haraken wrote:
>
> We're now removing the web/ directory as part of Onion Soup 2.0. web/ will be
> gone in the near future.
>
> Would you move this file to bindings/core/v8/?
>
Just to confirm before actually working for it.
You mean, we can use files under bindings/core/v8/ directly from
tools/blink_v8_snapshot/? Then I prefer to use
V8ContextSnapshotUtil::TakeSnapshot() instead. Is it allowed in Onion Soup 2.0?
haraken
2017/07/07 06:59:11
We should keep the public API in public/web/. We c
On 2017/07/07 06:22:04, peria wrote:
> On 2017/07/04 15:04:20, haraken wrote:
> >
> > We're now removing the web/ directory as part of Onion Soup 2.0. web/ will
be
> > gone in the near future.
> >
> > Would you move this file to bindings/core/v8/?
> >
>
> Just to confirm before actually working for it.
> You mean, we can use files under bindings/core/v8/ directly from
> tools/blink_v8_snapshot/? Then I prefer to use
> V8ContextSnapshotUtil::TakeSnapshot() instead. Is it allowed in Onion Soup
2.0?
We should keep the public API in public/web/. We can put the implementation in
bindings/core/v8/. tools/blink_v8_snapshot/ can use the public API.
(Once Onion Soup 2.0 is done, tools/blink_v8_snapshot/ can directly use
bindings/core/v8/, but we are not yet there.)
2 // Use of this source code is governed by a BSD-style license that can be
Issue 2841443005: [Bindings] Create and use V8 context snapshots
(Closed)
Created 3 years, 7 months ago by peria
Modified 3 years, 4 months ago
Reviewers: jochen (gone - plz use gerrit), agrieve, brettw, dcheng, eroman, haraken, jam, Michael Lippautz, rkc, Nico, Yuki, kinuko
Base URL:
Comments: 633