[Bindings] Create and use V8 context snapshots

third_party/WebKit/Source/bindings/core/v8/V8DOMConfiguration.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 10 matching lines @@
  * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
  * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
  * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
  * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "bindings/core/v8/V8DOMConfiguration.h"
 
+#include "bindings/core/v8/V8SnapshotCreator.h"
 #include "platform/bindings/V8ObjectConstructor.h"
 #include "platform/bindings/V8PerContextData.h"
 #include "platform/instrumentation/tracing/TraceEvent.h"
 
 namespace blink {
 
 namespace {
 
 template <class Configuration>
 bool WorldConfigurationApplies(const Configuration& config,
@@ skipping 654 matching lines @@
     prototype_template->SetInternalFieldCount(kV8PrototypeInternalFieldcount);
   }
 }
 
 v8::Local<v8::FunctionTemplate> V8DOMConfiguration::DomClassTemplate(
     v8::Isolate* isolate,
     const DOMWrapperWorld& world,
     WrapperTypeInfo* wrapper_type_info,
     InstallTemplateFunction configure_dom_class_template) {
   V8PerIsolateData* data = V8PerIsolateData::From(isolate);
-  v8::Local<v8::FunctionTemplate> result =
+  v8::Local<v8::FunctionTemplate> interface_template =
       data->FindInterfaceTemplate(world, wrapper_type_info);
-  if (!result.IsEmpty())
-    return result;
+  if (!interface_template.IsEmpty())
+    return interface_template;
 
-  result = v8::FunctionTemplate::New(
-      isolate, V8ObjectConstructor::IsValidConstructorMode);
-  configure_dom_class_template(isolate, world, result);
-  data->SetInterfaceTemplate(world, wrapper_type_info, result);
-  return result;
+  interface_template = V8SnapshotCreator::CreateInterfaceTemplate(

[Yuki, 2017/05/30 14:35:56]

nit: This seems not creating an interface template.
Extract, retrieve, get, deserialize, ... umm.
InterfaceTemplateFromSnapshot (following v8::FunctionTemplate::FromSnapshot) can
be an option (FromSnapshot could be redundant, though).

[peria, 2017/06/01 08:33:33]

Done.

+      isolate, world, wrapper_type_info);
+
+  if (interface_template.IsEmpty()) {
+    interface_template = v8::FunctionTemplate::New(
+        isolate, V8ObjectConstructor::IsValidConstructorMode);
+    configure_dom_class_template(isolate, world, interface_template);
+  }
+  data->SetInterfaceTemplate(world, wrapper_type_info, interface_template);
+  return interface_template;
 }
 
 void V8DOMConfiguration::SetClassString(
     v8::Isolate* isolate,
     v8::Local<v8::ObjectTemplate> object_template,
     const char* class_string) {
   object_template->Set(
       v8::Symbol::GetToStringTag(isolate),
       V8AtomicString(isolate, class_string),
       static_cast<v8::PropertyAttribute>(v8::ReadOnly | v8::DontEnum));
 }
 
 }  // namespace blink