Chromium Code Reviews| Index: chrome/browser/resources/settings/people_page/lock_screen.html |
| diff --git a/chrome/browser/resources/settings/people_page/lock_screen.html b/chrome/browser/resources/settings/people_page/lock_screen.html |
| index b7f13e876d2a827ef1a2c85adfb7375a27446946..fe1f7181f03071153e6781538bf4d38b8a0b0577 100644 |
| --- a/chrome/browser/resources/settings/people_page/lock_screen.html |
| +++ b/chrome/browser/resources/settings/people_page/lock_screen.html |
| @@ -19,65 +19,84 @@ |
| <dom-module id="settings-lock-screen"> |
| <template> |
| - <style include="settings-shared action-link"> |
| + <style include="settings-shared"> |
| #easyUnlock .start { |
| /* When the easy unlock toggle is shown, the easy unlock section's |
| * content becomes squashed to the top and bottom edges. Use padding to |
| - * ensure the easy unlock content looks correct. */ |
| + * ensure the easy unlock content looks correct. |
| + */ |
| padding: 11px 0; |
| } |
| + #lockOptionsDiv { |
| + display: block; |
| + } |
| + |
| paper-radio-button { |
| --paper-radio-button-label: { |
| display: flex; |
| + line-height: 154%; |
|
jdufault
2017/05/04 21:11:58
It may be more clear to specify this in pixels?
sammiequon
2017/05/04 23:55:37
I took this value from settings_var_css. Its used
jdufault
2017/05/05 00:13:44
Acknowledged.
|
| width: 100%; |
| }; |
| } |
| - paper-radio-button > .start { |
| - flex: 1; |
| + #pinPasswordDiv, |
| + #pinPasswordSecondaryActionDiv { |
| + margin: auto; |
| } |
| </style> |
| <div> |
| - <div class="list-frame"> |
| - <paper-radio-group id="unlockType" selected="{{selectedUnlockType}}"> |
| - <paper-radio-button name="password"> |
| - <div class="start"> |
| - $i18n{lockScreenPasswordOnly} |
| - <div class="secondary"> |
| - $i18n{lockScreenHighSecurity} |
| - </div> |
| - </div> |
| - </paper-radio-button> |
| - <paper-radio-button name="pin+password"> |
| - <div class="start"> |
| - $i18n{lockScreenPinOrPassword} |
| - <div class="secondary"> |
| - $i18n{lockScreenMediumSecurity} |
| - </div> |
| - </div> |
| - <template is="dom-if" |
| - if="[[showConfigurePinButton_(selectedUnlockType)]]"> |
| - <paper-button id="setupPinButton" class="secondary-button" |
| - on-tap="onConfigurePin_"> |
| - [[getSetupPinText_(hasPin)]] |
| - </paper-button> |
| - </template> |
| - </paper-radio-button> |
| - </paper-radio-group> |
| - </div> |
| - |
| - <div id="screenLockDiv" class="settings-box"> |
| + <div id="screenLockDiv" class="settings-box first"> |
| <settings-toggle-button class="start" |
| pref="{{prefs.settings.enable_screen_lock}}" |
| label="$i18n{enableScreenlock}"> |
| </settings-toggle-button> |
| </div> |
| + <div id="lockOptionsDiv"> |
| + <div class="settings-box"> |
| + <h2> $i18n{lockScreenOptions} </h2> |
|
jdufault
2017/05/04 21:11:58
spacing after start tag and before end tag (<h2>fo
sammiequon
2017/05/04 23:55:37
Done.
|
| + </div> |
| + <div class="list-frame"> |
| + <paper-radio-group id="unlockType" selected="{{selectedUnlockType}}"> |
| + <paper-radio-button name="password" |
| + class="settings-box first two-line"> |
| + <div class="start"> |
| + $i18n{lockScreenPasswordOnly} |
| + <div class="secondary"> |
| + $i18n{lockScreenHighSecurity} |
| + </div> |
| + </div> |
| + </paper-radio-button> |
| + <paper-radio-button name="pin+password" |
| + class="settings-box two-line"> |
| + <div id="pinPasswordDiv" class="start"> |
| + $i18n{lockScreenPinOrPassword} |
| + <div class="secondary"> |
| + $i18n{lockScreenMediumSecurity} |
| + </div> |
| + </div> |
| + <template is="dom-if" |
| + if="[[showConfigurePinButton_(selectedUnlockType)]]"> |
| + <div class="separator"></div> |
| + <div id="pinPasswordSecondaryActionDiv" |
| + class="secondary-action"> |
| + <paper-button id="setupPinButton" class="secondary-button" |
| + on-tap="onConfigurePin_"> |
| + [[getSetupPinText_(hasPin)]] |
| + </paper-button> |
| + </div> |
| + </template> |
| + </paper-radio-button> |
| + <div class="settings-box line-only"></div> |
| + </paper-radio-group> |
| + </div> |
| + </div> |
| + |
| <template is="dom-if" if="[[fingerprintUnlockEnabled_]]"> |
| <div id="fingerprintDiv"> |
| - <div class="settings-box"> |
| + <div class="settings-box continuation"> |
| <settings-toggle-button class="start" |
| pref="{{prefs.settings.enable_quick_unlock_fingerprint}}" |
| label="$i18n{lockScreenFingerprintEnable}"> |
| @@ -85,24 +104,29 @@ |
| </div> |
| <iron-collapse |
| opened="[[prefs.settings.enable_quick_unlock_fingerprint.value]]"> |
| - <div class="settings-box continuation" on-tap="onEditFingerprints_" |
| - actionable> |
| + <div class="settings-box continuation"> |
| <div class="start"> |
| $i18n{lockScreenEditFingerprints} |
| <div class="secondary" id="lockScreenEditFingerprintsSecondary"> |
| [[getDescriptionText_(numFingerprints_)]] |
| </div> |
| </div> |
| - <button class="subpage-arrow" is="paper-icon-button-light" |
| - aria-label="$i18n{lockScreenEditFingerprints}" |
| - aria-describedby="lockScreenEditFingerprintsSecondary"></button> |
| + <div class="separator"></div> |
| + <div class="secondary-action"> |
| + <paper-button class="secondary-button" |
| + on-tap="onEditFingerprints_" |
| + aria-label="$i18n{lockScreenEditFingerprints}" |
| + aria-descibedby="lockScreenEditFingerprintsSecondary"> |
| + $i18n{lockScreenSetupFingerprintButton} |
| + </paper-button> |
| + </div> |
| </div> |
| </iron-collapse> |
| </div> |
| </template> |
| <template is="dom-if" if="[[easyUnlockAllowed_]]"> |
| - <div id="easyUnlock" class="settings-box two-line"> |
| + <div id="easyUnlock" class="settings-box two-line continuation"> |
| <div class="start"> |
| <div>$i18n{easyUnlockSectionTitle}</div> |
| <div class="secondary"> |