android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java - Issue 284123004: [android_webview] Add more params to request intercepting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

Issue 284123004: [android_webview] Add more params to request intercepting. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix accidentally broken test Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerStartupTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

index 4943bf8d9c7dc0997fb7bb39571d4da77552dcc5..38bfbd1adc7554bb1ef5168198785e06ddc742ac 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

@@ -21,9 +21,10 @@ import static org.chromium.base.test.util.ScalableTimeout.scaleTimeout;

import org.apache.http.Header;

import org.apache.http.HttpRequest;

import org.chromium.android_webview.AwContents;

+import org.chromium.android_webview.AwContentsClient.ShouldInterceptRequestParams;

import org.chromium.android_webview.AwSettings;

import org.chromium.android_webview.AwSettings.LayoutAlgorithm;

-import org.chromium.android_webview.InterceptedRequestData;

+import org.chromium.android_webview.AwWebResourceResponse;

import org.chromium.android_webview.test.util.CommonResources;

import org.chromium.android_webview.test.util.ImagePageGenerator;

import org.chromium.android_webview.test.util.VideoTestUtil;

@@ -2568,8 +2569,9 @@ public class AwSettingsTest extends AwTestBase {

final String DEFAULT_VIDEO_POSTER_URL = "http://default_video_poster/";

TestAwContentsClient client = new TestAwContentsClient() {

@Override

- public InterceptedRequestData shouldInterceptRequest(String url) {

- if (url.equals(DEFAULT_VIDEO_POSTER_URL)) {

+ public AwWebResourceResponse shouldInterceptRequest(

+ ShouldInterceptRequestParams params) {

+ if (params.url.equals(DEFAULT_VIDEO_POSTER_URL)) {

videoPosterAccessedCallbackHelper.notifyCalled();

}

return null;