android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientGetDefaultVideoPosterTest.java - Issue 284123004: [android_webview] Add more params to request intercepting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientGetDefaultVideoPosterTest.java

Issue 284123004: [android_webview] Add more params to request intercepting. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix accidentally broken test Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/InterceptedRequestData.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldInterceptRequestTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientGetDefaultVideoPosterTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientGetDefaultVideoPosterTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientGetDefaultVideoPosterTest.java

index 8891fb982215b81fbe2beb870a0ab36bf22c10de..fea72ffa9374c8d643bdef135e7e50468b89ab2e 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientGetDefaultVideoPosterTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientGetDefaultVideoPosterTest.java

@@ -10,8 +10,8 @@ import android.graphics.BitmapFactory;

import android.test.suitebuilder.annotation.SmallTest;

import android.util.Log;

+import org.chromium.android_webview.AwWebResourceResponse;

import org.chromium.android_webview.DefaultVideoPosterRequestHandler;

-import org.chromium.android_webview.InterceptedRequestData;

import org.chromium.base.test.util.Feature;

import org.chromium.content.browser.test.util.CallbackHelper;

@@ -77,7 +77,7 @@ public class AwContentsClientGetDefaultVideoPosterTest extends AwTestBase {

new DefaultVideoPosterClient(getInstrumentation().getTargetContext());

DefaultVideoPosterRequestHandler handler =

new DefaultVideoPosterRequestHandler(contentsClient);

- InterceptedRequestData requestData =

+ AwWebResourceResponse requestData =

handler.shouldInterceptRequest(handler.getDefaultVideoPosterURL());

assertTrue(requestData.getMimeType().equals("image/png"));

Bitmap bitmap = BitmapFactory.decodeStream(requestData.getData());

@@ -94,7 +94,7 @@ public class AwContentsClientGetDefaultVideoPosterTest extends AwTestBase {

NullContentsClient contentsClient = new NullContentsClient();