content/browser/service_worker/service_worker_storage.h - Issue 284123003: ServiceWorker: DB functions should return status code instead of boolean (3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_storage.h

Issue 284123003: ServiceWorker: DB functions should return status code instead of boolean (3) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_database_unittest.cc ('k') | content/browser/service_worker/service_worker_storage.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_storage.h

diff --git a/content/browser/service_worker/service_worker_storage.h b/content/browser/service_worker/service_worker_storage.h

index a0183dbf131f1870f4ebd6b775bc0ccb3224907c..d815bf8cdf6b298498b343c6eb980f18fe3d8f8b 100644

--- a/content/browser/service_worker/service_worker_storage.h

+++ b/content/browser/service_worker/service_worker_storage.h

@@ -151,8 +151,8 @@ class CONTENT_EXPORT ServiceWorkerStorage {

ServiceWorkerDatabase::Status status);

void DidReadRegistrationForId(

const FindRegistrationCallback& callback,

- const ServiceWorkerDatabase::RegistrationData& registration,

- const ResourceList& resources,

+ ServiceWorkerDatabase::RegistrationData* registration,

+ ResourceList* resources,

ServiceWorkerDatabase::Status status);

void DidGetAllRegistrations(

const GetAllRegistrationInfosCallback& callback,

@@ -161,7 +161,10 @@ class CONTENT_EXPORT ServiceWorkerStorage {

void DidStoreRegistration(

const GURL& origin,

const StatusCallback& callback,

- bool success);

+ ServiceWorkerDatabase::Status status);

+ void DidUpdateToActiveState(

+ const StatusCallback& callback,

+ ServiceWorkerDatabase::Status status);

void DidDeleteRegistration(

const GURL& origin,

const StatusCallback& callback,