dart2js-kernel: Bind type variables in generative constructor.

dart2js-kernel: Bind type variables in generative constructor.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/9635a84d327ea4beb40a3c9a1387250b2fbf5adb

[sra1, 2017-04-26 21:41:06]

Patchset #1 (id:1) has been deleted

[sra1, 2017-04-26 23:49:10]

Patchset #1 (id:20001) has been deleted

[sra1, 2017-04-26 23:49:38]

Description was changed from

==========
dart2js-kernel: Bind type variable in generative constructor.
==========

to

==========
dart2js-kernel: Bind type variables in generative constructor.
==========

[sra1, 2017-04-26 23:49:39]

sra@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-04-27 00:32:27]

lgtm!

Only silly nits.

Note that our bots are running now tests with --use-kernel, so you might need to
update some .status files.

https://codereview.chromium.org/2841213002/diff/40001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2841213002/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:258: ///  1. Extend method
parameters with parameters the class's type parameters.
with parameters the => with the

https://codereview.chromium.org/2841213002/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:267: ///     initializer.
"intializer" => "initializer assignments"? or "initializer expressions"?

https://codereview.chromium.org/2841213002/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:269: ///  5. Create reified type
information for instance.
nit: for instance => for the object instance? (I read it as "For instance, an
example will follow")

https://codereview.chromium.org/2841213002/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:271: ///  6. Allocate instance and
assign initializers and reified type information
instance => object instance

https://codereview.chromium.org/2841213002/diff/40001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/builder_kernel.dart:278: /// future support repeated
uses of a mixin class, we should do so by cloning
in future => in the future

[sra1, 2017-04-27 23:07:12]

Description was changed from

==========
dart2js-kernel: Bind type variables in generative constructor.
==========

to

==========
dart2js-kernel: Bind type variables in generative constructor.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9635a84d327ea4beb40a3c9a1387250b2fbf5adb
==========

[sra1, 2017-04-27 23:07:13]

Committed patchset #3 (id:80001) manually as
9635a84d327ea4beb40a3c9a1387250b2fbf5adb (presubmit successful).