Implement privacy disclosure for an unbound webapk.

chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkDisclosureNotificationManager.java

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkDisclosureNotificationManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkDisclosureNotificationManager.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkDisclosureNotificationManager.java
new file mode 100644
index 0000000000000000000000000000000000000000..5fc75a0b5a8f28acbb22143420c31d841f338759
--- /dev/null
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkDisclosureNotificationManager.java
@@ -0,0 +1,64 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.webapps;
+
+import android.app.Notification;
+import android.content.Context;
+import android.graphics.BitmapFactory;
+
+import org.chromium.base.ContextUtils;
+import org.chromium.chrome.R;
+import org.chromium.chrome.browser.notifications.NotificationUmaTracker;
+import org.chromium.chrome.browser.notifications.StandardNotificationBuilder;
+import org.chromium.chrome.browser.notifications.WebApkNotificationClient;
+import org.chromium.chrome.browser.notifications.channels.ChannelDefinitions;
+
+import java.util.Random;
+
+/**
+ * Manages the notification indicating that a WebApk is backed by chrome code and may share data.
+ */
+public class WebApkDisclosureNotificationManager {
+    private static final String WEBAPK_OPEN_TAG = "webapk_notification";
+
+    /**
+     * Shows the privacy disclosure informing the user that Chrome is being used.
+     * @param webappInfo Web App this is currently displayed fullscreen.
+     * @param storage
+         * @return identifier used to display the notification

[awdf, 2017/05/24 14:47:42]

nit: indentation is weird

+     */
+    public static int showDisclosure(WebappInfo webappInfo, WebappDataStorage storage) {

[dominickn, 2017/05/24 01:24:36]

The WebappDataStorage isn't currently used in here? Perhaps it could be passed
to getDeleteIntent in place of the ID (WebappDataStorage should only be used on
the UI thread so this should be safe)?

Otherwise omit?

[Yaron, 2017/05/24 14:59:25]

omitted - can't pass it as part of the intent so prefer to stick with a string
extra

+        Context context = ContextUtils.getApplicationContext();
+        String title = webappInfo.shortName();
+
+        StandardNotificationBuilder builder = new StandardNotificationBuilder(context);
+        builder.setTitle(title)
+                .setVisibility(Notification.VISIBILITY_SECRET)
+                .setLargeIcon(BitmapFactory.decodeResource(
+                        context.getResources(), R.drawable.ic_launcher))
+                .setDeleteIntent(WebApkDisclosureNotificationService.getDeleteIntent(
+                        context, webappInfo.id()))
+                .setBody(context.getResources().getString(
+                        R.string.webapk_running_in_chrome_disclosure, title));
+
+        int id = (new Random()).nextInt();
+        WebApkNotificationClient.notifyNotification(webappInfo.webApkPackageName(),
+                builder, WEBAPK_OPEN_TAG, id);
+        // Even though the Notification is shown via the WebApk, we still want to record UMA.
+        NotificationUmaTracker.getInstance().onNotificationShown(
+                NotificationUmaTracker.WEBAPK, ChannelDefinitions.CHANNEL_ID_BROWSER);

[awdf, 2017/05/24 14:47:42]

Here you're recording that the notification is assigned to the Browser channel,
but actually the StandardNotificationBuilder (SNB) sets the channel id to
CHANNEL_ID_SITES under the hood. You probably want to use the Browser channel in
both places, since the browser channel is for silent notifications whereas the
sites channel uses default sound/vibrate options.*

The fact the SNB is hardcoded to the SITES channel is a bug - the SNB is
intended to be usable for any notifications, not tied to web notifications
(although it's only used for web notifications right now).

To fix this, I would make the channel ID a constructor-parameter of the SNB, and
then check the channel id instead of VISIBILITY SECRET when conditionally
setting vibrate etc.

(Or, you could change this back to using chrome's wrapper of NotificationBuilder
and we can fix up SNB to be more generic at a later date, if/when we start using
it for all Chrome notifications.. I would slightly prefer the other solution,
but ok with this too)

*In practice these notifications won't actually be sent to any channel until we
create channels for WebApks, once they start targeting O, so the channel
properties will be ignored, but let's keep things consistent for simplicity.

+        return id;
+    }
+
+    /**
+     * Dismisses the notification.
+     * @param webappInfo Web App this is currently displayed fullscreen.
+     * @param id The identifier for the tag to dismiss.
+     */
+    public static void dismissNotification(WebappInfo webappInfo, int id) {
+        WebApkNotificationClient.cancelNotification(
+                webappInfo.webApkPackageName(), WEBAPK_OPEN_TAG, id);
+    }
+}