chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java - Issue 2841193002: Implement privacy disclosure for an unbound webapk.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java

Issue 2841193002: Implement privacy disclosure for an unbound webapk. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java

index 171b7b58a7ca2195c4bfde8f93feedbdeefc621f..42667d8029037d3f1a0f3bc978a303f0306e014b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java

@@ -58,8 +58,11 @@ public class StandardNotificationBuilder extends NotificationBuilderBase {

if (mSettingsAction != null) {

addActionToBuilder(builder, mSettingsAction);

}

- builder.setDefaults(mDefaults);

- builder.setVibrate(mVibratePattern);

+ builder.setVisibility(mVisibility);

+ if (mVisibility != Notification.VISIBILITY_SECRET) {

+ builder.setDefaults(mDefaults);

+ builder.setVibrate(mVibratePattern);

+ }

builder.setWhen(mTimestamp);

builder.setOnlyAlertOnce(!mRenotify);

setGroupOnBuilder(builder, mOrigin);