chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java - Issue 2841193002: Implement privacy disclosure for an unbound webapk.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java

Issue 2841193002: Implement privacy disclosure for an unbound webapk. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/AndroidManifest.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderBase.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java

index a1f62659779c1fd1e66f34247ff6f7ed1c3669e1..4c4bd027357344c8fae331c8e7a0364c634302ec 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java

@@ -146,8 +146,11 @@ public class CustomNotificationBuilder extends NotificationBuilderBase {

builder.setTicker(mTickerText);

builder.setContentIntent(mContentIntent);

builder.setDeleteIntent(mDeleteIntent);

- builder.setDefaults(mDefaults);

- builder.setVibrate(mVibratePattern);

+ builder.setVisibility(mVisibility);

+ if (mVisibility != Notification.VISIBILITY_SECRET) {

awdf 2017/05/24 14:47:42 maybe change this to check a new channel id field

+ builder.setDefaults(mDefaults);

+ builder.setVibrate(mVibratePattern);

+ }

builder.setWhen(mTimestamp);

builder.setOnlyAlertOnce(!mRenotify);

builder.setContent(compactView);