Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6304)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

Issue 2841193002: Implement privacy disclosure for an unbound webapk. (Closed)
Patch Set: Implement privacy disclosure for an unbound webapk. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
index a3843dd67433afd96b26248ca9db269c4703a2c8..fc5b665ce9a88bd5dc036321c73f968cea4c97b6 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java
@@ -4,6 +4,8 @@
package org.chromium.chrome.browser.webapps;
+import static org.chromium.webapk.lib.common.WebApkConstants.WEBAPK_PACKAGE_PREFIX;
+
import android.content.Intent;
import android.os.Bundle;
import android.os.SystemClock;
@@ -92,8 +94,19 @@ public class WebApkActivity extends WebappActivity {
}
@Override
+ public void onStartWithNative() {
+ super.onStartWithNative();
+ if (!getWebApkPackageName().startsWith(WEBAPK_PACKAGE_PREFIX)) {
+ // If we're showing a WebApk that's not with an expected package, it must be an
+ // "Unbound WebApk" (crbug/714735) so show a notification that it's backed by Chrome.
pkotwicz 2017/05/02 18:03:29 crbug/714735 -> crbug.com/714735
Yaron 2017/05/24 01:13:15 Done.
+ WebApkDisclosureNotificationManager.showDisclosure(mWebappInfo);
+ }
+ }
+
+ @Override
public void onStop() {
super.onStop();
+ WebApkDisclosureNotificationManager.dismissNotification();
WebApkServiceConnectionManager.getInstance().disconnect(
ContextUtils.getApplicationContext(), getWebApkPackageName());
}

Powered by Google App Engine
This is Rietveld 408576698