Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2953)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java

Issue 2841193002: Implement privacy disclosure for an unbound webapk. (Closed)
Patch Set: nit Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java
index 513c5a81a0c0417f7af2a7a6be708d173c74efc3..c39a2e2923b11f2d48c8ce10f26bd2dd5989bca9 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/StandardNotificationBuilder.java
@@ -16,8 +16,9 @@ import org.chromium.chrome.browser.notifications.channels.ChannelDefinitions;
public class StandardNotificationBuilder extends NotificationBuilderBase {
private final Context mContext;
- public StandardNotificationBuilder(Context context) {
- super(context.getResources());
+ public StandardNotificationBuilder(
+ Context context, @ChannelDefinitions.ChannelId String channelId) {
+ super(context.getResources(), channelId);
mContext = context;
}
@@ -28,7 +29,7 @@ public class StandardNotificationBuilder extends NotificationBuilderBase {
// TODO(crbug.com/697104) We should probably use a Compat builder.
ChromeNotificationBuilder builder =
NotificationBuilderFactory.createChromeNotificationBuilder(
- false /* preferCompat */, ChannelDefinitions.CHANNEL_ID_SITES);
+ false /* preferCompat */, mChannelId);
builder.setContentTitle(mTitle);
builder.setContentText(mBody);
@@ -57,8 +58,12 @@ public class StandardNotificationBuilder extends NotificationBuilderBase {
if (mSettingsAction != null) {
addActionToBuilder(builder, mSettingsAction);
}
- builder.setDefaults(mDefaults);
- builder.setVibrate(mVibratePattern);
+ builder.setPriority(mPriority);
+ // Browser channel uses silent notifications to avoid disrupting the user.
+ if (!ChannelDefinitions.CHANNEL_ID_BROWSER.equals(mChannelId)) {
+ builder.setDefaults(mDefaults);
+ builder.setVibrate(mVibratePattern);
+ }
builder.setWhen(mTimestamp);
builder.setOnlyAlertOnce(!mRenotify);
setGroupOnBuilder(builder, mOrigin);

Powered by Google App Engine
This is Rietveld 408576698