Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java

Issue 2841193002: Implement privacy disclosure for an unbound webapk. (Closed)
Patch Set: fix test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java
index a1f62659779c1fd1e66f34247ff6f7ed1c3669e1..a53e8ea61d856a60cb1aa13462b057508f1425a5 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java
@@ -80,7 +80,8 @@ public class CustomNotificationBuilder extends NotificationBuilderBase {
private final Context mContext;
public CustomNotificationBuilder(Context context) {
- super(context.getResources());
+ // TODO(yfriedman): Pass in the ChannelDefinition
+ super(context.getResources(), ChannelDefinitions.CHANNEL_ID_SITES);
mContext = context;
}
@@ -142,12 +143,15 @@ public class CustomNotificationBuilder extends NotificationBuilderBase {
// TODO(crbug.com/697104) We should probably use a Compat builder.
ChromeNotificationBuilder builder =
NotificationBuilderFactory.createChromeNotificationBuilder(
- false /* preferCompat */, ChannelDefinitions.CHANNEL_ID_SITES);
+ false /* preferCompat */, mChannelId);
builder.setTicker(mTickerText);
builder.setContentIntent(mContentIntent);
builder.setDeleteIntent(mDeleteIntent);
- builder.setDefaults(mDefaults);
- builder.setVibrate(mVibratePattern);
+ builder.setPriority(mPriority);
+ if (!ChannelDefinitions.CHANNEL_ID_BROWSER.equals(mChannelId)) {
Yaron 2017/05/24 18:08:29 do you want a comment saying that Browser channel
awdf 2017/05/25 13:56:45 yes please.
+ builder.setDefaults(mDefaults);
+ builder.setVibrate(mVibratePattern);
+ }
builder.setWhen(mTimestamp);
builder.setOnlyAlertOnce(!mRenotify);
builder.setContent(compactView);

Powered by Google App Engine
This is Rietveld 408576698