Implement privacy disclosure for an unbound webapk.

chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkActivity.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.webapps;
 
+import static org.chromium.webapk.lib.common.WebApkConstants.WEBAPK_PACKAGE_PREFIX;
+
 import android.content.Intent;
 import android.os.Bundle;
 import android.os.SystemClock;
 
 import org.chromium.base.ContextUtils;
 import org.chromium.base.library_loader.LibraryProcessType;
 import org.chromium.base.metrics.RecordHistogram;
 import org.chromium.base.process_launcher.ChildProcessCreationParams;
 import org.chromium.chrome.browser.externalnav.ExternalNavigationParams;
 import org.chromium.chrome.browser.metrics.WebApkUma;
@@ skipping 17 matching lines @@
 
     /** Indicates whether launching renderer in WebAPK process is enabled. */
     private boolean mCanLaunchRendererInWebApkProcess;
 
     private final ChildProcessCreationParams mDefaultParams =
             ChildProcessCreationParams.getDefault();
 
     /** The start time that the activity becomes focused. */
     private long mStartTime;
 
+    /** Records whether we're currently showing a disclosure notification. */
+    private boolean mNotificationShown;
+
     @Override
     protected WebappInfo createWebappInfo(Intent intent) {
         return (intent == null) ? WebApkInfo.createEmpty() : WebApkInfo.create(intent);
     }
 
     @Override
     protected void initializeUI(Bundle savedInstance) {
         super.initializeUI(savedInstance);
         getActivityTab().setWebappManifestScope(mWebappInfo.scopeUri().toString());
     }
@@ skipping 41 matching lines @@
     }
 
     @Override
     public void onStop() {
         super.onStop();
         WebApkServiceConnectionManager.getInstance().disconnect(
                 ContextUtils.getApplicationContext(), getWebApkPackageName());
     }
 
     @Override
+    public void onStartWithNative() {
+        super.onStartWithNative();
+        // If WebappStorage is available, check whether to show a disclosure notification. If it's
+        // not available, this check will happen once deferred startup returns with the storage
+        // instance.
+        WebappDataStorage storage =
+                WebappRegistry.getInstance().getWebappDataStorage(mWebappInfo.id());
+        if (storage != null) maybeShowDisclosure(storage);
+    }
+
+    @Override
     public void onStopWithNative() {
         super.onStopWithNative();
+        if (mNotificationShown) {
+            WebApkDisclosureNotificationManager.dismissNotification(mWebappInfo);
+            mNotificationShown = false;
+        }
         if (mUpdateManager != null && mUpdateManager.requestPendingUpdate()) {
             WebApkUma.recordUpdateRequestSent(WebApkUma.UPDATE_REQUEST_SENT_ONSTOP);
         }
     }
 
     /**
      * Returns the WebAPK's package name.
      */
     public String getWebApkPackageName() {
         return getWebappInfo().webApkPackageName();
@@ skipping 26 matching lines @@
 
     @Override
     protected void onDeferredStartupWithStorage(WebappDataStorage storage) {
         super.onDeferredStartupWithStorage(storage);
 
         WebApkInfo info = (WebApkInfo) mWebappInfo;
         WebApkUma.recordShellApkVersion(info.shellApkVersion(), info.webApkPackageName());
 
         mUpdateManager = new WebApkUpdateManager(WebApkActivity.this, storage);
         mUpdateManager.updateIfNeeded(getActivityTab(), info);
+
+        maybeShowDisclosure(storage);

[pkotwicz, 2017/05/25 22:08:42]

It is possible for onDeferredStartup() to be called prior to onStartWithNative()
if a user opens a WebAPK and switches to recents immediately. This occurs
because native is loaded after onStop() is called.

This means that it is possible for the notification to show when the WebAPK is
not in the foreground.

[Yaron, 2017/05/26 14:33:00]

Done.

+    }
+
+    /**
+     * If we're showing a WebApk that's not with an expected package, it must be an
+     * "Unbound WebApk" (crbug.com/714735) so show a notification that it's running in Chrome.
+     */
+    private void maybeShowDisclosure(WebappDataStorage storage) {
+        if (!getWebApkPackageName().startsWith(WEBAPK_PACKAGE_PREFIX)
+                && !storage.hasDismissedDisclosure() && !mNotificationShown) {
+            mNotificationShown = true;
+            WebApkDisclosureNotificationManager.showDisclosure(mWebappInfo);
+        }
     }
 
     @Override
     protected void onDeferredStartupWithNullStorage() {
         super.onDeferredStartupWithNullStorage();
 
         // Register the WebAPK. The WebAPK is not registered when it is created so it has to be
         // registered now. The WebAPK may also become unregistered after a user clears Chrome's
         // data.
         WebappRegistry.getInstance().register(
@@ skipping 40 matching lines @@
     }
 
     @Override
     protected void onDestroyInternal() {
         if (mUpdateManager != null) {
             mUpdateManager.destroy();
         }
         super.onDestroyInternal();
     }
 }