Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Issue 2841133002: [Media Router] Actually return an object after creating a controller in bindings (Closed)

Created:
3 years, 8 months ago by takumif
Modified:
3 years, 8 months ago
Reviewers:
imcheng
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Actually return an object after creating a controller in bindings As mentioned in [1], we need to wrap an object literal in parentheses when returning it from a concise arrow function. [1] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions#Returning_object_literals Review-Url: https://codereview.chromium.org/2841133002 Cr-Commit-Position: refs/heads/master@{#467432} Committed: https://chromium.googlesource.com/chromium/src/+/7957cd3f4c677c7580e5dd386da5c7e60a5c5a9a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/renderer/resources/extensions/media_router_bindings.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
takumif
Please take a look. I manually tested that it actually returns the object this time. ...
3 years, 8 months ago (2017-04-26 19:00:09 UTC) #4
imcheng
lgtm. Good catch, thanks!
3 years, 8 months ago (2017-04-26 19:36:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841133002/1
3 years, 8 months ago (2017-04-26 20:07:00 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 20:17:57 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7957cd3f4c677c7580e5dd386da5...

Powered by Google App Engine
This is Rietveld 408576698