Issue 284113008: Cleanup of ViewManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 284113008: Cleanup of ViewManager (Closed)

Created:
6 years, 7 months ago by sky

Modified:
6 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Cleanup of ViewManager Make some methods take Node/View* instead of NodeId/ViewId. These functions needs the Nodes anyway, so no point in converting to id, then back to node multiple times. Also remove TODOs that aren't going to happen. BUG=365012 TEST=covered by tests R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271044

Patch Set 1 #

Patch Set 2 : merge to trunk #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -113 lines)			Patch
M	mojo/services/view_manager/node.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/services/view_manager/node.cc	View		2 chunks	+17 lines, -16 lines	0 comments	Download
M	mojo/services/view_manager/node_delegate.h	View		1 chunk	+8 lines, -8 lines	0 comments	Download
M	mojo/services/view_manager/root_node_manager.h	View		2 chunks	+12 lines, -12 lines	0 comments	Download
M	mojo/services/view_manager/root_node_manager.cc	View		4 chunks	+14 lines, -18 lines	0 comments	Download
M	mojo/services/view_manager/type_converters.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/services/view_manager/type_converters.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	mojo/services/view_manager/view_manager_connection.h	View	1	3 chunks	+17 lines, -18 lines	0 comments	Download
M	mojo/services/view_manager/view_manager_connection.cc	View	1	9 chunks	+39 lines, -36 lines	0 comments	Download
M	mojo/services/view_manager/view_manager_connection_unittest.cc	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

6 years, 7 months ago (2014-05-16 17:34:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r271044 (presubmit successful).

Expand Messages | Collapse Messages