Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1378)

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_impl.cc

Issue 284113006: Enable new session crashed bubble UI by Finch experiment. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Address comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/ui/views/session_crashed_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/startup/startup_browser_creator_impl.cc
diff --git a/chrome/browser/ui/startup/startup_browser_creator_impl.cc b/chrome/browser/ui/startup/startup_browser_creator_impl.cc
index f3f7fa4fd635f846a75eb19ebfb6e2a14a10fcb6..d912d94925beb76a791ab818e37525983e0ad3e6 100644
--- a/chrome/browser/ui/startup/startup_browser_creator_impl.cc
+++ b/chrome/browser/ui/startup/startup_browser_creator_impl.cc
@@ -838,14 +838,9 @@ void StartupBrowserCreatorImpl::AddInfoBarsIfNecessary(
if (!browser || !profile_ || browser->tab_strip_model()->count() == 0)
return;
- if (HasPendingUncleanExit(browser->profile())) {
- // Can't use command_line_ here because command_line_ isn't set to have
- // correct values when a profile window is opened after the browser starts
- // up (via profile switcher). See function FindOrCreateNewWindowForProfile.
- if (!CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnableSessionCrashedBubble) ||
- !ShowSessionCrashedBubble(browser))
- SessionCrashedInfoBarDelegate::Create(browser);
+ if (HasPendingUncleanExit(browser->profile()) &&
+ !ShowSessionCrashedBubble(browser)) {
+ SessionCrashedInfoBarDelegate::Create(browser);
}
// The below info bars are only added to the first profile which is launched.
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/ui/views/session_crashed_bubble_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698