Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 284113005: Use `git rev-list A..B` to get the list of commits to be uploaded to Gerrit by git cl. (Closed)

Created:
6 years, 7 months ago by Bernhard Bauer
Modified:
6 years, 7 months ago
Reviewers:
iannucci, newt (away)
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org, newt (away)
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Use `git rev-list A..B` to get the list of commits to be uploaded to Gerrit by git cl. BUG=374121 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=270972

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M git_cl.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/git_cl_test.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Bernhard Bauer
Please review.
6 years, 7 months ago (2014-05-15 16:24:32 UTC) #1
newt (away)
lgtm, thanks!
6 years, 7 months ago (2014-05-15 18:22:58 UTC) #2
iannucci
There should probably be a bug to track the problem, diagnosis and fix. C+P from ...
6 years, 7 months ago (2014-05-15 19:13:41 UTC) #3
Bernhard Bauer
On 2014/05/15 19:13:41, iannucci wrote: > There should probably be a bug to track the ...
6 years, 7 months ago (2014-05-16 08:34:06 UTC) #4
Bernhard Bauer
The CQ bit was checked by bauerb@chromium.org
6 years, 7 months ago (2014-05-16 08:34:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/284113005/1
6 years, 7 months ago (2014-05-16 08:34:29 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 08:36:06 UTC) #7
commit-bot: I haz the power
Presubmit check for 284113005-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 7 months ago (2014-05-16 08:36:06 UTC) #8
iannucci
lgtm
6 years, 7 months ago (2014-05-16 09:06:29 UTC) #9
Bernhard Bauer
The CQ bit was checked by bauerb@chromium.org
6 years, 7 months ago (2014-05-16 09:20:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/284113005/1
6 years, 7 months ago (2014-05-16 09:20:34 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 09:22:10 UTC) #12
Message was sent while issue was closed.
Change committed as 270972

Powered by Google App Engine
This is Rietveld 408576698