Issue 284113002: Always return a subrole when the Mac accessibility role is AXList.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 284113002: Always return a subrole when the Mac accessibility role is AXList. (Closed)

Created:
6 years, 7 months ago by dmazzoni

Modified:
6 years, 7 months ago

Reviewers:
aboxhall

CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Always return a subrole when the Mac accessibility role is AXList. We already had tests for <ul>, <ol>, and <dl>, but not for <div role="list">, but it seems simplest to just always return a subrole of AXContentList by default and AXDescriptionList only for <dl>, since VoiceOver gets confused if it isn't one of those two. BUG=373498 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271239

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -5 lines)			Patch
M	content/browser/accessibility/browser_accessibility_cocoa.mm	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	content/browser/accessibility/dump_accessibility_tree_browsertest.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	content/test/data/accessibility/aria-list.html	View	1 chunk	+12 lines, -0 lines	0 comments	Download
A +	content/test/data/accessibility/aria-list-expected-android.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	content/test/data/accessibility/aria-list-expected-mac.txt	View	1 chunk	+0 lines, -3 lines	0 comments	Download
A +	content/test/data/accessibility/aria-list-expected-win.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/284113002/1

6 years, 7 months ago (2014-05-17 02:31:59 UTC) #5

Message was sent while issue was closed.

Change committed as 271239

Expand Messages | Collapse Messages