third_party/WebKit/Source/core/input/EventHandler.cpp - Issue 2841093002: Algorithm for deciding if a frame's selection should be hidden

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/input/EventHandler.cpp

Issue 2841093002: Algorithm for deciding if a frame's selection should be hidden (Closed)

Patch Set: More robust logic (no need to modify LayoutTests?) and new C++ unit tests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/input/EventHandler.cpp

diff --git a/third_party/WebKit/Source/core/input/EventHandler.cpp b/third_party/WebKit/Source/core/input/EventHandler.cpp

index e8eb453d76839e49a7a01538684714985bd0bef8..4664abec80bcbd229fd60e0babfc8a6d29dcd9b5 100644

--- a/third_party/WebKit/Source/core/input/EventHandler.cpp

+++ b/third_party/WebKit/Source/core/input/EventHandler.cpp

@@ -1818,7 +1818,7 @@ WebInputEventResult EventHandler::SendContextMenuEventForKey(

selection.ComputeVisibleSelectionInDOMTreeDeprecated().Start();

VisualViewport& visual_viewport = frame_->GetPage()->GetVisualViewport();

- if (!override_target_element && start.AnchorNode() &&

+ if (!override_target_element && start.AnchorNode() && !selection.IsHidden() &&

(selection.ComputeVisibleSelectionInDOMTreeDeprecated()

.RootEditableElement() ||

selection.ComputeVisibleSelectionInDOMTreeDeprecated().IsRange())) {