Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: third_party/WebKit/Source/core/editing/LayoutSelection.h

Issue 2841093002: Algorithm for deciding if a frame's selection should be hidden (Closed)
Patch Set: More robust logic (no need to modify LayoutTests?) and new C++ unit tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/LayoutSelection.h
diff --git a/third_party/WebKit/Source/core/editing/LayoutSelection.h b/third_party/WebKit/Source/core/editing/LayoutSelection.h
index b49f079a950aabb0b1e108ad526ad9326aa35f7f..0aaac932affd6d256577db5515e3508395ccd532 100644
--- a/third_party/WebKit/Source/core/editing/LayoutSelection.h
+++ b/third_party/WebKit/Source/core/editing/LayoutSelection.h
@@ -32,14 +32,12 @@ class FrameSelection;
class LayoutSelection final : public GarbageCollected<LayoutSelection> {
public:
- enum class PaintHint { kHide, kKeep, kPaint };
-
static LayoutSelection* Create(FrameSelection& frame_selection) {
return new LayoutSelection(frame_selection);
}
bool HasPendingSelection() const { return has_pending_selection_; }
- void SetHasPendingSelection(PaintHint);
+ void SetHasPendingSelection() { has_pending_selection_ = true; }
void Commit();
IntRect SelectionBounds();
@@ -70,7 +68,6 @@ class LayoutSelection final : public GarbageCollected<LayoutSelection> {
Member<FrameSelection> frame_selection_;
bool has_pending_selection_ : 1;
- bool force_hide_ : 1;
// The current selection represented as 2 boundaries.
// Selection boundaries are represented in LayoutView by a tuple

Powered by Google App Engine
This is Rietveld 408576698