Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2499)

Unified Diff: pkg/analysis_server/lib/src/domain_server.dart

Issue 284103005: move context id constant to AnalysisServer (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/domain_server.dart
diff --git a/pkg/analysis_server/lib/src/domain_server.dart b/pkg/analysis_server/lib/src/domain_server.dart
index 102a79c2f77e2ade4812d8ba1d411ec4479273c0..495024a9dc715679db8da8de19fbf23cc461a316 100644
--- a/pkg/analysis_server/lib/src/domain_server.dart
+++ b/pkg/analysis_server/lib/src/domain_server.dart
@@ -38,11 +38,6 @@ class ServerDomainHandler implements RequestHandler {
static const String VERSION_METHOD = 'server.version';
/**
- * The name of the contextId parameter.
- */
- static const String CONTEXT_ID_PARAM = 'contextId';
-
- /**
* The name of the packageMap parameter.
*/
static const String PACKAGE_MAP_PARAM = 'packageMap';
@@ -95,7 +90,7 @@ class ServerDomainHandler implements RequestHandler {
String sdkDirectory = request.getRequiredParameter(SDK_DIRECTORY_PARAM).asString();
Map<String, String> packageMap = request.getParameter(PACKAGE_MAP_PARAM, {}).asStringMap();
- String contextId = request.getRequiredParameter(CONTEXT_ID_PARAM).asString();
+ String contextId = request.getRequiredParameter(AnalysisServer.CONTEXT_ID_PARAM).asString();
if (server.contextMap.containsKey(contextId)) {
return new Response.contextAlreadyExists(request);
}
@@ -126,7 +121,7 @@ class ServerDomainHandler implements RequestHandler {
* will result in an error being returned.
*/
Response deleteContext(Request request) {
- String contextId = request.getRequiredParameter(CONTEXT_ID_PARAM).asString();
+ String contextId = request.getRequiredParameter(AnalysisServer.CONTEXT_ID_PARAM).asString();
AnalysisContext removedContext = server.contextMap.remove(contextId);
if (removedContext == null) {
« no previous file with comments | « pkg/analysis_server/lib/src/analysis_server.dart ('k') | pkg/analysis_server/test/analysis_server_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698