chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc - Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc

Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address issue exposed by failing unit test. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc ('k') | chrome/browser/ui/webui/extensions/extension_settings_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc

diff --git a/chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc b/chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc

index e1a66c8f5f9b45265ab30965103ba6952a5f23d9..8db6baa4c41c35866762c2cbfbb35b91c0e6cf35 100644

--- a/chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc

+++ b/chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc

@@ -207,7 +207,9 @@ void BookmarkAppBubbleView::WindowClosing() {

if (remove_app_) {

GetExtensionService(profile_)->UninstallExtension(

- extension_id_, false, NULL);

+ extension_id_,

+ ExtensionService::UNINSTALL_REASON_INSTALL_CANCELED,

+ NULL);

} else {

ApplyEdits();

}