chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc - Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc

Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address issue exposed by failing unit test. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/background/background_application_list_model_unittest.cc ('k') | chrome/browser/extensions/api/management/management_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc

diff --git a/chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc b/chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc

index 3919cbed569c618331ba3cd05a5b2f05cca260bd..b5ad5d05f89b275e976b84ff5cbe24086caa621d 100644

--- a/chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc

+++ b/chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc

@@ -188,7 +188,8 @@ TEST_F(ActivityLogEnabledTest, WatchdogSwitch) {

EXPECT_TRUE(activity_log1->IsDatabaseEnabled());

EXPECT_FALSE(activity_log2->IsDatabaseEnabled());

- extension_service1->UninstallExtension(kExtensionID, false, NULL);

+ extension_service1->UninstallExtension(

+ kExtensionID, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);

EXPECT_EQ(0,

profile1->GetPrefs()->GetInteger(prefs::kWatchdogExtensionActive));

@@ -263,7 +264,8 @@ TEST_F(ActivityLogEnabledTest, AppAndCommandLine) {

profile->GetPrefs()->GetInteger(prefs::kWatchdogExtensionActive));

EXPECT_TRUE(activity_log->IsWatchdogAppActive());

- extension_service->UninstallExtension(kExtensionID, false, NULL);

+ extension_service->UninstallExtension(

+ kExtensionID, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);

EXPECT_TRUE(activity_log->IsDatabaseEnabled());

EXPECT_EQ(0,