chrome/browser/apps/ephemeral_app_service.cc - Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/ephemeral_app_service.cc

Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address issue exposed by failing unit test. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/ephemeral_app_browsertest.cc ('k') | chrome/browser/background/background_application_list_model_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/apps/ephemeral_app_service.cc

diff --git a/chrome/browser/apps/ephemeral_app_service.cc b/chrome/browser/apps/ephemeral_app_service.cc

index 067de9cc7067b990e3fd5b764774ab13a0f68a0e..da4a5d19ab9b5b79956e6ffd82be4a38ea52e4de 100644

--- a/chrome/browser/apps/ephemeral_app_service.cc

+++ b/chrome/browser/apps/ephemeral_app_service.cc

@@ -194,8 +194,12 @@ void EphemeralAppService::GarbageCollectApps() {

GetAppsToRemove(app_count, app_launch_times, &remove_app_ids);

for (std::set<std::string>::const_iterator id = remove_app_ids.begin();

id != remove_app_ids.end(); ++id) {

- if (service->UninstallExtension(*id, false, NULL))

+ if (service->UninstallExtension(

+ *id,

+ ExtensionService::UNINSTALL_REASON_ORPHANED_EPHEMERAL_EXTENSION,

+ NULL)) {

--app_count;

+ }

}