Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3802)

Unified Diff: chrome/browser/apps/drive/drive_app_provider.cc

Issue 284103002: Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address issue exposed by failing unit test. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/apps/ephemeral_app_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/apps/drive/drive_app_provider.cc
diff --git a/chrome/browser/apps/drive/drive_app_provider.cc b/chrome/browser/apps/drive/drive_app_provider.cc
index 2bde9fe6bafb0eb97ba67f3d422cdcf8e9306743..3aeb5a03e001a0834f533c2d5bff442918aa1234 100644
--- a/chrome/browser/apps/drive/drive_app_provider.cc
+++ b/chrome/browser/apps/drive/drive_app_provider.cc
@@ -82,7 +82,9 @@ void DriveAppProvider::UpdateMappingAndExtensionSystem(
if (existing_app && is_existing_app_generated) {
extensions::ExtensionSystem::Get(profile_)
->extension_service()
- ->UninstallExtension(existing_chrome_app_id, false, NULL);
+ ->UninstallExtension(existing_chrome_app_id,
+ ExtensionService::UNINSTALL_REASON_SYNC,
+ NULL);
}
}
@@ -191,7 +193,8 @@ void DriveAppProvider::ProcessRemovedDriveApp(const std::string& drive_app_id) {
extensions::ExtensionSystem::Get(profile_)
->extension_service()
- ->UninstallExtension(chrome_app_id, false, NULL);
+ ->UninstallExtension(
+ chrome_app_id, ExtensionService::UNINSTALL_REASON_SYNC, NULL);
}
void DriveAppProvider::OnDriveAppRegistryUpdated() {
« no previous file with comments | « no previous file | chrome/browser/apps/ephemeral_app_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698