Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method.

chrome/browser/extensions/extension_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
 
 #include <list>
 #include <map>
 #include <set>
@@ skipping 110 matching lines @@
 };
 
 // Manages installed and running Chromium extensions. An instance is shared
 // between normal and incognito profiles.
 class ExtensionService
     : public ExtensionServiceInterface,
       public extensions::ExternalProviderInterface::VisitorInterface,
       public content::NotificationObserver,
       public extensions::Blacklist::Observer {
  public:
+  enum UninstallReason {
+    kUninstallReasonDefault,

[Devlin, 2014/05/14 23:14:20]

For better or worse, Extensions code overwhelmingly uses SCREAMING_STYLE for
enums.

[rpaquay, 2014/06/30 23:16:18]

Done.

+    kUninstallReasonOrphanedSharedModule,
+    kUninstallReasonOrphanedTheme,
+    kUninstallReasonOrphanedExternalExtension,
+    kUninstallReasonOrphanedEphemeralExtension,
+    kUninstallReasonUserInitiated,
+    kUninstallReasonSynch,

[Devlin, 2014/05/14 23:14:20]

nit: "Sync" is more common spelling in the code.

[rpaquay, 2014/06/30 23:16:18]

Done.

+  };
+
   // Attempts to uninstall an extension from a given ExtensionService. Returns
   // true iff the target extension exists.
   static bool UninstallExtensionHelper(ExtensionService* extensions_service,
-                                       const std::string& extension_id);
+                                       const std::string& extension_id,
+                                       UninstallReason reason);
 
   // Constructor stores pointers to |profile| and |extension_prefs| but
   // ownership remains at caller.
   ExtensionService(Profile* profile,
                    const base::CommandLine* command_line,
                    const base::FilePath& install_directory,
                    extensions::ExtensionPrefs* extension_prefs,
                    extensions::Blacklist* blacklist,
                    bool autoupdate_enabled,
                    bool extensions_enabled,
@@ skipping 44 matching lines @@
       const std::string& id,
       const base::FilePath& extension_path,
       bool file_ownership_passed,
       extensions::CrxInstaller** out_crx_installer) OVERRIDE;
 
   // Reloads the specified extension, sending the onLaunched() event to it if it
   // currently has any window showing.
   void ReloadExtension(const std::string extension_id);
 
   // Uninstalls the specified extension. Callers should only call this method
-  // with extensions that exist. |external_uninstall| is a magical parameter
-  // that is only used to send information to ExtensionPrefs, which external
-  // callers should never set to true.
-  //
-  // We pass the |extension_id| by value to avoid having it deleted from under
-  // us incase someone calls it with Extension::id() or another string that we
-  // are going to delete in this function.
-  //
-  // TODO(aa): Remove |external_uninstall| -- this information should be passed
-  // to ExtensionPrefs some other way.
+  // with extensions that exist. |reason| lets the caller specify why the
+  // extension is uninstalled.
   virtual bool UninstallExtension(const std::string& extension_id,
-                                  bool external_uninstall,
+                                  UninstallReason reason,
                                   base::string16* error);
 
   virtual bool IsExtensionEnabled(
       const std::string& extension_id) const OVERRIDE;
 
   // Enables the extension.  If the extension is already enabled, does
   // nothing.
   virtual void EnableExtension(const std::string& extension_id);
 
   // Disables the extension.  If the extension is already disabled, or
@@ skipping 486 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
                            GreylistedExtensionDisabled);
   FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
                            GreylistDontEnableManuallyDisabled);
   FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
                            GreylistUnknownDontChange);
   DISALLOW_COPY_AND_ASSIGN(ExtensionService);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_