Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2091)

Unified Diff: chrome/browser/net/passive_log_collector.cc

Issue 2841010: Speculative workaround for a crash. Not sure how it could reach this state, b... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/passive_log_collector.cc
===================================================================
--- chrome/browser/net/passive_log_collector.cc (revision 50149)
+++ chrome/browser/net/passive_log_collector.cc (working copy)
@@ -181,7 +181,11 @@
void PassiveLogCollector::SourceTracker::DeleteSourceInfo(
uint32 source_id) {
SourceIDToInfoMap::iterator it = sources_.find(source_id);
- DCHECK(it != sources_.end());
+ if (it == sources_.end()) {
+ // TODO(eroman): Is this happening? And if so, why.
+ LOG(WARNING) << "Tried to delete info for nonexistent source";
+ return;
+ }
// The source should not be in the deletion queue.
DCHECK(std::find(deletion_queue_.begin(), deletion_queue_.end(),
source_id) == deletion_queue_.end());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698