Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2840843003: [Android O] Initialize notification channels on OS upgrade (Closed)

Created:
3 years, 8 months ago by awdf
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android O] Initialize notification channels on OS upgrade - We now trigger channel initialization on upgrade to O, so that users receiving an OS update do not have to wait until Chrome is opened to start seeing all of Chrome's channels in Android notification settings. - Since there is no broadcast to listen to for OS upgrade, we instead listen for BOOT_COMPLETED, and then check if the device is on O and has not already initialized channels. BUG=710926

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -12 lines) Patch
M chrome/android/java/AndroidManifest.xml View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/ChannelsUpdater.java View 2 chunks +14 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/upgrade/BootCompletedBroadcastReceiver.java View 1 chunk +33 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/upgrade/PackageReplacedBroadcastReceiver.java View 2 chunks +1 line, -12 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
awdf
3 years, 8 months ago (2017-04-25 14:34:55 UTC) #2 
On 2017/04/25 14:32:16, awdf wrote:
> Description was changed from
> 
> ==========
> [Android O] Initialize notification channels on OS upgrade
> 
> - We now trigger channel initialization on upgrade to O, so that users
> receiving an OS update do not have to wait until Chrome next updates to
> start seeing all of Chrome's channels in Android notification settings.
> 
> - Since there is no broadcast to listen to for OS upgrade, we instead
> listen for BOOT_COMPLETED, and then check if the device is on O and
> has not already initialized channels.
> 
> BUG=710926
> ==========
> 
> to
> 
> ==========
> [Android O] Initialize notification channels on OS upgrade
> 
> - We now trigger channel initialization on upgrade to O, so that users
> receiving an OS update do not have to wait until Chrome is opened to
> start seeing all of Chrome's channels in Android notification settings.
> 
> - Since there is no broadcast to listen to for OS upgrade, we instead
> listen for BOOT_COMPLETED, and then check if the device is on O and
> has not already initialized channels.
> 
> BUG=710926
> ==========

Closing this review since I now realise that channels would still be
initialized on first launch of the app since OS upgrade, which seems good
enough for now.

Powered by Google App Engine
This is Rietveld 408576698