ui/views/animation/ink_drop_host_view.cc - Issue 2840773003: views: Button ripple/highlight is visible during shelf swipe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/animation/ink_drop_host_view.cc

Issue 2840773003: views: Button ripple/highlight is visible during shelf swipe. (Closed)

Patch Set: Rebased. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/animation/ink_drop_host_view.cc

diff --git a/ui/views/animation/ink_drop_host_view.cc b/ui/views/animation/ink_drop_host_view.cc

index 789f1b5e76eb05885906fafa8285d549cbc0dc59..d358e0c153185198d24b9370ddba3395963c3157 100644

--- a/ui/views/animation/ink_drop_host_view.cc

+++ b/ui/views/animation/ink_drop_host_view.cc

@@ -75,7 +75,7 @@ class InkDropHostView::InkDropGestureHandler : public ui::EventHandler {

ink_drop_state = InkDropState::ALTERNATE_ACTION_TRIGGERED;

break;

case ui::ET_GESTURE_END:

- case ui::ET_GESTURE_SCROLL_BEGIN:

+ case ui::ET_GESTURE_TAP_CANCEL:

bruthig 2017/04/27 13:58:46 Do you know if a TAP_CANCEL happen whenever a SCRO

sammiequon 2017/04/28 04:58:03 Oops, I did not mean to remove the SCROLL_BEGIN he

if (current_ink_drop_state == InkDropState::ACTIVATED)

return;

ink_drop_state = InkDropState::HIDDEN;

« no previous file with comments | « ash/shelf/shelf_view_unittest.cc ('k') | no next file » | no next file with comments »