Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 284073002: Remove software paint path from WebTestProxy (Closed)

Created:
6 years, 7 months ago by enne (OOO)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

Remove software paint path from WebTestProxy BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270959

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -121 lines) Patch
M content/shell/renderer/test_runner/web_test_proxy.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 4 chunks +1 line, -82 lines 1 comment Download
M content/shell/renderer/webkit_test_runner.cc View 2 chunks +3 lines, -35 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
enne (OOO)
All layout tests should be force composited now. Remove these old codepaths and replace with ...
6 years, 7 months ago (2014-05-14 21:42:14 UTC) #1
danakj
LGTM https://codereview.chromium.org/284073002/diff/1/content/shell/renderer/test_runner/web_test_proxy.cc File content/shell/renderer/test_runner/web_test_proxy.cc (right): https://codereview.chromium.org/284073002/diff/1/content/shell/renderer/test_runner/web_test_proxy.cc#newcode515 content/shell/renderer/test_runner/web_test_proxy.cc:515: CHECK(web_widget_->isAcceleratedCompositingActive()); this could equivalently be a DCHECK i ...
6 years, 7 months ago (2014-05-15 14:29:35 UTC) #2
enne (OOO)
+sky if you want to review this, since you looked at the follow-on patch here: ...
6 years, 7 months ago (2014-05-15 21:02:22 UTC) #3
sky
LGTM
6 years, 7 months ago (2014-05-15 22:38:50 UTC) #4
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 7 months ago (2014-05-15 22:48:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/284073002/1
6 years, 7 months ago (2014-05-15 22:51:19 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 04:44:35 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 04:48:40 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/68062)
6 years, 7 months ago (2014-05-16 04:48:40 UTC) #9
jochen (gone - plz use gerrit)
lgtm
6 years, 7 months ago (2014-05-16 07:09:53 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 08:05:02 UTC) #11
Message was sent while issue was closed.
Change committed as 270959

Powered by Google App Engine
This is Rietveld 408576698