Refactoring analyzer_cli for code hygiene.

Refactoring analyzer_cli for code hygiene.

BUG=
R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/3bad1dfb4c2bb2f34b92988f203c840aacc1f703

[devoncarew, 2017-04-24 20:03:24]

devoncarew@google.com changed reviewers:
+ brianwilkerson@google.com, danrubel@google.com

[devoncarew, 2017-04-24 20:03:25]

Mechanical refactorings to analyzer_cli to improve code hygiene:

- move all batch mode related code into a new 'batch_mode.dart' file
- some file name refactorings for consistency with the other files, and for
clarity

[Brian Wilkerson, 2017-04-24 20:26:47]

Moving batch mode out to a separate file makes a lot of sense. The file renames
seem gratuitous to me, and I'd rather not have them. Other than that, lgtm.

https://codereview.chromium.org/2840703002/diff/1/pkg/analyzer_cli/lib/src/an...
File pkg/analyzer_cli/lib/src/analyzer_driver.dart (right):

https://codereview.chromium.org/2840703002/diff/1/pkg/analyzer_cli/lib/src/an...
pkg/analyzer_cli/lib/src/analyzer_driver.dart:1: // Copyright (c) 2015, the Dart
project authors.  Please see the AUTHORS file
I don't understand why the name of the file was changed. (1) We generally use
file names that match the name of the primary class, which in this case is
Driver. (2) We use the name 'driver.dart' in analysis_server, so it  would be
easier to find if we used the same name in both places. (3) I know the name of
this file, so making unmotivated changes (if this is one) only makes me have to
re-learn where to find the code I'm looking for.

https://codereview.chromium.org/2840703002/diff/1/pkg/analyzer_cli/lib/src/an...
File pkg/analyzer_cli/lib/src/analyzer_options.dart (right):

https://codereview.chromium.org/2840703002/diff/1/pkg/analyzer_cli/lib/src/an...
pkg/analyzer_cli/lib/src/analyzer_options.dart:1: // Copyright (c) 2015, the
Dart project authors.  Please see the AUTHORS file
If you're going to bother to rename this (and I don't see any value in it), it
should probably be named 'command_line_options.dart'.

https://codereview.chromium.org/2840703002/diff/1/pkg/analyzer_cli/lib/src/ba...
File pkg/analyzer_cli/lib/src/batch_mode.dart (right):

https://codereview.chromium.org/2840703002/diff/1/pkg/analyzer_cli/lib/src/ba...
pkg/analyzer_cli/lib/src/batch_mode.dart:1: // Copyright (c) 2017, the Dart
project authors.  Please see the AUTHORS file
We generally keep the copyright date from the old file when moving code out into
a new file. Not sure whether it makes any difference, though.

[devoncarew, 2017-04-24 22:10:01]

Some file name changes reverted -

https://codereview.chromium.org/2840703002/diff/1/pkg/analyzer_cli/lib/src/an...
File pkg/analyzer_cli/lib/src/analyzer_driver.dart (right):

https://codereview.chromium.org/2840703002/diff/1/pkg/analyzer_cli/lib/src/an...
pkg/analyzer_cli/lib/src/analyzer_driver.dart:1: // Copyright (c) 2015, the Dart
project authors.  Please see the AUTHORS file
On 2017/04/24 20:26:47, Brian Wilkerson wrote:
> I don't understand why the name of the file was changed. (1) We generally use
> file names that match the name of the primary class, which in this case is
> Driver. (2) We use the name 'driver.dart' in analysis_server, so it  would be
> easier to find if we used the same name in both places. (3) I know the name of
> this file, so making unmotivated changes (if this is one) only makes me have
to
> re-learn where to find the code I'm looking for.

I can change this name back to 'driver.dart'. It was odd to me to have the file
'analyzer_impl.dart' prefixed with analyzer, and not to have the entrypoint be
prefixed as well. Perhaps there's a better way to factor the impl file which
would lead to a more descriptive name.

https://codereview.chromium.org/2840703002/diff/1/pkg/analyzer_cli/lib/src/an...
File pkg/analyzer_cli/lib/src/analyzer_options.dart (right):

https://codereview.chromium.org/2840703002/diff/1/pkg/analyzer_cli/lib/src/an...
pkg/analyzer_cli/lib/src/analyzer_options.dart:1: // Copyright (c) 2015, the
Dart project authors.  Please see the AUTHORS file
On 2017/04/24 20:26:47, Brian Wilkerson wrote:
> If you're going to bother to rename this (and I don't see any value in it), it
> should probably be named 'command_line_options.dart'.

No strong preference here - my intent was to make this match the
'analyzer_impl.dart' and 'analyzer_driver.dart' file name pattern. I can revert
this.

[Brian Wilkerson, 2017-04-24 22:56:41]

lgtm, thanks

[devoncarew, 2017-04-24 23:55:41]

Description was changed from

==========
Refactoring analyzer_cli for code hygiene.

BUG=
==========

to

==========
Refactoring analyzer_cli for code hygiene.

BUG=
R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3bad1dfb4c2bb2f34b92988f203c840aacc1f703
==========

[devoncarew, 2017-04-24 23:55:42]

Committed patchset #2 (id:20001) manually as
3bad1dfb4c2bb2f34b92988f203c840aacc1f703 (presubmit successful).